Skip to content

[feat] support converter for torch.log2 #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2024
Merged

[feat] support converter for torch.log2 #2620

merged 1 commit into from
Mar 4, 2024

Conversation

bowang007
Copy link
Collaborator

Description

Support converter for torch.log2

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jan 23, 2024
@github-actions github-actions bot requested a review from apbose January 23, 2024 20:32
gs-olive
gs-olive reviewed Jan 24, 2024
View reviewed changes
zewenli98
zewenli98 reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just need some minor changes.

github-actions[bot]
github-actions bot requested changes Feb 2, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited by bowang007
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated

apbose
apbose reviewed Mar 4, 2024
View reviewed changes
@bowang007 bowang007 merged commit ad74a73 into main Mar 4, 2024
@bowang007 bowang007 deleted the log2_converter branch October 24, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 left review comments

@gs-olive gs-olive gs-olive left review comments

@github-actions github-actions[bot] github-actions[bot] requested changes

@apbose apbose apbose approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@peri044 peri044 Awaiting requested review from peri044

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bowang007 @zewenli98 @apbose @gs-olive @facebook-github-bot