full_like evaluator #2917
Closed
full_like evaluator #2917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
peri044
requested changes
Jun 13, 2024
Comment on lines
20
to
+21
| from torch_tensorrt.fx.types import TRTTensor | ||
| from torch_tensorrt.fx.utils import Frameworks, unified_dtype_converter |
There was a problem hiding this comment.
We have our own types and switch from unified_dtype_converter to using _enums.dtype.to and _enums.dtype.from for type conversions. We shouldn't be using FX utils anymore.
| full_like_np_tensor = None | ||
| tensor_shape = args[0].shape | ||
| if kwargs.get("dtype") is not None: | ||
| full_like_np_tensor = np.full( |
There was a problem hiding this comment.
Can you also add dynamic shape support ? what if the input shape has -1 in it ? Please refer to fill layer which can help you out here.
|
@apbose what is the status of full_like ? |
|
I did not work on this since long. I should be able to take a look at this next week when I am done with dynamic shape of aten::chunk and aten::tile and merge the remaining PRs. |
|
Closing this as we now have a lowering pass that handles this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.