refactor: Upgrade bazel and move to MODULE.bazel #3012
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ) | ||
|
|
||
| local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "local_repository") | ||
|
|
||
| # External dependency for torch_tensorrt if you already have precompiled binaries. | ||
| local_repository( | ||
| name = "torch_tensorrt", | ||
| path = "/opt/conda/lib/python3.8/site-packages/torch_tensorrt", |
There was a problem hiding this comment.
Should this still be python3.8?
There was a problem hiding this comment.
I think we just use this for DLFW CI so @apbose might know
There was a problem hiding this comment.
The DLFW CI uses the WORKSPACE.ngc within the docker folder. python3.10 is used there-
# External dependency for torch_tensorrt if you already have precompiled binaries.
# This is currently used in pytorch NGC container CI testing.
local_repository(
name = "torch_tensorrt",
path = "/usr/local/lib/python3.10/dist-packages/torch_tensorrt/"
)
@narendasan based on the MODULE.bazel it will use bazel_dep to handle torchTRT dependencies. So what are the use cases when it will use the local_repository rule as compared to the bazel_dep dependencies?
There was a problem hiding this comment.
Local repositories still exist for MODULE.bazel, there is just now a bazel package repository for common packages that we use
narendasan
force-pushed
the
bzlmod
branch
6 times, most recently
from
ac76ed2 to
335b338
Compare
github-actions
bot
added
component: api [Python]
Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
| git_override( | ||
| module_name = "rules_pkg", | ||
| commit = "17c57f4", | ||
| remote = "https://github.com/narendasan/rules_pkg", |
There was a problem hiding this comment.
Any reason for overriding specific commit and for usage of your own repo ?
There was a problem hiding this comment.
Theres an issue with building as root in the container without the patches in my fork
| @@ -8,11 +8,11 @@ pip install tensorrt==${TRT_VERSION} tensorrt-${CU_VERSION::4}-bindings==${TRT_V | |||
|
|
|||
| choco install bazelisk -y | |||
|
|
|||
| curl -Lo TensorRT.zip https://developer.nvidia.com/downloads/compute/machine-learning/tensorrt/10.1.0/zip/TensorRT-10.1.0.27.Windows.win10.cuda-12.4.zip | |||
| unzip -o TensorRT.zip -d C:/ | |||
| #curl -Lo TensorRT.zip https://developer.download.nvidia.com/compute/machine-learning/tensorrt/10.0.1/zip/TensorRT-10.0.1.6.Windows10.win10.cuda-12.4.zip | |||
There was a problem hiding this comment.
doesn't need to change to TRT 10.0 I think, although it's commented out.
Description
Fixes the issues with compiling with bazel directly and upgrades to the MODULE.bazel system
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: