Skip to content

Fix failed TestNativeLayerNormConverter #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2024
Merged

Fix failed TestNativeLayerNormConverter #3315

merged 3 commits into from
Dec 16, 2024

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Dec 9, 2024

Description

FAILED conversion\test_layer_norm_aten.py::TestNativeLayerNormConverter::test_layer_norm_1d_0 - torch_tensorrt.dynamo.conversion._TRTInterpreter.UnsupportedOperatorException: Conversion of function torch._ops.aten.aten::native_layer_norm not currently supported!

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added the component: tests Issues re: Tests label Dec 9, 2024
@github-actions github-actions bot requested a review from narendasan December 9, 2024 13:29
@narendasan narendasan requested a review from apbose December 10, 2024 20:09
peri044
peri044 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit b0b6f38 into pytorch:main Dec 16, 2024
66 of 68 checks passed
@HolyWu HolyWu deleted the fix_test_layer_norm branch December 16, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@apbose apbose apbose approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees
No one assigned
Labels
cla signed component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HolyWu @peri044 @apbose @facebook-github-bot