Skip to content

Add aten::layer_norm support and move add_elementwise to utils #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 4, 2021
Merged

Add aten::layer_norm support and move add_elementwise to utils #446

merged 5 commits into from
May 4, 2021

Conversation

chengyute
Copy link
Contributor

@chengyute chengyute commented May 4, 2021 •
edited
Loading

Description

Add aten::layer_norm support and move add_elementwise to core/conversion/converters/converter_util.h

Fixes # 278

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels May 4, 2021
github-actions[bot]
github-actions bot approved these changes May 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@chengyute chengyute force-pushed the yutec/layer_norm_elementwise_util branch from c51a606 to 93cf6d6 Compare May 4, 2021 18:16
github-actions[bot]
github-actions bot approved these changes May 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@chengyute chengyute assigned chengyute and narendasan and unassigned chengyute May 4, 2021
@narendasan narendasan linked an issue May 4, 2021 that may be closed by this pull request
↔ [Converter] Add support for layer_norm in TRTorch #278
Closed
narendasan
narendasan reviewed May 4, 2021
View reviewed changes
core/conversion/converters/impl/layer_norm.cpp Outdated
namespace impl {
namespace {

nvinfer1::ILayer* add_elementwise(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed now right?

github-actions[bot]
github-actions bot approved these changes May 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@narendasan narendasan merged commit bb668db into master May 4, 2021
@narendasan narendasan deleted the yutec/layer_norm_elementwise_util branch May 4, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@narendasan narendasan

Labels
component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

↔ [Converter] Add support for layer_norm in TRTorch
2 participants
@chengyute @narendasan