Skip to content

feat(//core/plugins): Gating plugin logging based on global config #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021

Conversation

narendasan
Copy link
Collaborator

Description

Uses global config to set reportable logging level

Superseeds: #458

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@narendasan narendasan requested a review from peri044 May 13, 2021 21:05
@github-actions github-actions bot added the component: core Issues re: The core compiler label May 13, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/core/plugins/register_plugins.cpp b/tmp/changes.txt
index 14283b6..a576e78 100644
--- a/workspace/core/plugins/register_plugins.cpp
+++ b/tmp/changes.txt
@@ -41,8 +41,10 @@ class TRTorchPluginRegistry {
  }

 public:
-  util::logging::TRTorchLogger plugin_logger =
-      util::logging::TRTorchLogger("[TRTorch Plugins Context] - ", util::logging::get_logger().get_reportable_log_level(), util::logging::get_logger().get_is_colored_output_on());
+  util::logging::TRTorchLogger plugin_logger = util::logging::TRTorchLogger(
+      "[TRTorch Plugins Context] - ",
+      util::logging::get_logger().get_reportable_log_level(),
+      util::logging::get_logger().get_is_colored_output_on());
};

namespace {
ERROR: Some files do not conform to style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/core/plugins/register_plugins.cpp b/tmp/changes.txt
index 14283b6..a576e78 100644
--- a/workspace/core/plugins/register_plugins.cpp
+++ b/tmp/changes.txt
@@ -41,8 +41,10 @@ class TRTorchPluginRegistry {
  }

 public:
-  util::logging::TRTorchLogger plugin_logger =
-      util::logging::TRTorchLogger("[TRTorch Plugins Context] - ", util::logging::get_logger().get_reportable_log_level(), util::logging::get_logger().get_is_colored_output_on());
+  util::logging::TRTorchLogger plugin_logger = util::logging::TRTorchLogger(
+      "[TRTorch Plugins Context] - ",
+      util::logging::get_logger().get_reportable_log_level(),
+      util::logging::get_logger().get_is_colored_output_on());
};

namespace {
ERROR: Some files do not conform to style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@narendasan narendasan merged commit 7765d8c into master May 13, 2021
@narendasan narendasan deleted the plugin_logging branch May 13, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Issues re: The core compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant