-
Notifications
You must be signed in to change notification settings - Fork 363
feat(//core/plugins): Gating plugin logging based on global config #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/core/plugins/register_plugins.cpp b/tmp/changes.txt
index 14283b6..a576e78 100644
--- a/workspace/core/plugins/register_plugins.cpp
+++ b/tmp/changes.txt
@@ -41,8 +41,10 @@ class TRTorchPluginRegistry {
}
public:
- util::logging::TRTorchLogger plugin_logger =
- util::logging::TRTorchLogger("[TRTorch Plugins Context] - ", util::logging::get_logger().get_reportable_log_level(), util::logging::get_logger().get_is_colored_output_on());
+ util::logging::TRTorchLogger plugin_logger = util::logging::TRTorchLogger(
+ "[TRTorch Plugins Context] - ",
+ util::logging::get_logger().get_reportable_log_level(),
+ util::logging::get_logger().get_is_colored_output_on());
};
namespace {
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/core/plugins/register_plugins.cpp b/tmp/changes.txt
index 14283b6..a576e78 100644
--- a/workspace/core/plugins/register_plugins.cpp
+++ b/tmp/changes.txt
@@ -41,8 +41,10 @@ class TRTorchPluginRegistry {
}
public:
- util::logging::TRTorchLogger plugin_logger =
- util::logging::TRTorchLogger("[TRTorch Plugins Context] - ", util::logging::get_logger().get_reportable_log_level(), util::logging::get_logger().get_is_colored_output_on());
+ util::logging::TRTorchLogger plugin_logger = util::logging::TRTorchLogger(
+ "[TRTorch Plugins Context] - ",
+ util::logging::get_logger().get_reportable_log_level(),
+ util::logging::get_logger().get_is_colored_output_on());
};
namespace {
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
1d417e4
to
1d5a088
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
Description
Uses global config to set reportable logging level
Superseeds: #458
Checklist: