Skip to content

fix(runtime): Fix document generator failure for non-GPU host machines #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Jul 14, 2021

Signed-off-by: Anurag Dixit [email protected]

Description

Changed assert to warning logs. Document generation is not applicable to host machines with GPU cards. Hence, failure to read any CUDA-capable device is not a valid use case scenario.

Fixes # (issue)

Bug fix (non-breaking change)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

Signed-off-by: Anurag Dixit <[email protected]>
@andi4191 andi4191 requested a review from narendasan July 14, 2021 00:52
@andi4191 andi4191 self-assigned this Jul 14, 2021
@github-actions github-actions bot added component: core Issues re: The core compiler component: runtime labels Jul 14, 2021
@andi4191 andi4191 changed the title Rebase Fix document generator failure for non-GPU host machines Jul 14, 2021
@andi4191 andi4191 changed the title Fix document generator failure for non-GPU host machines fix(runtime): Fix document generator failure for non-GPU host machines Jul 14, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit ab0efb4 into master Jul 14, 2021
@narendasan narendasan deleted the anuragd/docs branch July 14, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Issues re: The core compiler component: runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants