refactor!: Removing deprecated InputRange, op_precision and input_shapes #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APIs BREAKING CHANGE: This removes the InputRange Class and op_precision and input shape fields which were deprecated in TRTorch v0.4.0 Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
github-actions
bot
added
component: api [Python]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
peri044
approved these changes
Sep 22, 2021
| @@ -81,7 +81,7 @@ def test(model, dataloader, crit): | |||
| import trtorch | |||
| # trtorch.logging.set_reportable_log_level(trtorch.logging.Level.Debug) | |||
| compile_settings = { | |||
| "input_shapes": [[1, 3, 32, 32]], | |||
| "inputs": [trtorch.Input([1, 3, 32, 32])], | |||
| "op_precision": torch.int8 # Run with FP16 | |||
There was a problem hiding this comment.
We can change this to enabled_precisions: {torch.int8}. I can do this in a separate PR if you want to merge this quick.
There was a problem hiding this comment.
ill just add it to this one
Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
narendasan
force-pushed
the
remove_deprecated_apis
branch
from
fc037c2 to
f8b1866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIs
Description
BREAKING CHANGE: This removes the InputRange Class and op_precision and
input shape fields which were deprecated in TRTorch v0.4.0
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: