Skip to content

fix: Guard test activation for CI testing #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Nov 15, 2021

Signed-off-by: Anurag Dixit [email protected]

Description

Aligning the CI testing guard for test_activation unit test case. This will make sure that the test suite is consistent across different release guarded by CI.

Fixes # (issue)

Type of change

Non-Breaking change
Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@andi4191 andi4191 requested a review from narendasan November 15, 2021 21:27
@andi4191 andi4191 self-assigned this Nov 15, 2021
@github-actions github-actions bot added the component: tests Issues re: Tests label Nov 15, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@narendasan
Copy link
Collaborator

narendasan commented Nov 15, 2021

@andi4191 can you put together an index of tests we disable for CI? We should be updating this list as we enable and disable tests

@andi4191
Copy link
Contributor Author

@narendasan : I added the list of tests for tracking in this PR:
#738

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andi4191 andi4191 merged commit a234edd into master Nov 24, 2021
@andi4191 andi4191 deleted the anuragd/ci_flag_guard_test_activation branch February 24, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants