Skip to content

Updated README to point to NGC container #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ncomly-nvidia
Copy link
Contributor

@ncomly-nvidia ncomly-nvidia commented Nov 30, 2021

Signed-off-by: Nick Comly [email protected]

Description

Updating README to direct users to NGC container immediately for download.

Type of change

  • Documentation fix. Makes distribution easier

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /workspace/tests/py/test_api.py	(original)
+++ /workspace/tests/py/test_api.py	(reformatted)
@@ -32,9 +32,9 @@
    def test_compile_script(self):
        with torch.no_grad():
            trt_mod = torchtrt.ts.compile(self.scripted_model,
-                                      inputs=[self.input],
-                                      device=torchtrt.Device(gpu_id=0),
-                                      enabled_precisions={torch.float})
+                                          inputs=[self.input],
+                                          device=torchtrt.Device(gpu_id=0),
+                                          enabled_precisions={torch.float})
            same = (trt_mod(self.input) - self.scripted_model(self.input)).abs().max()
            self.assertTrue(same < 2e-2)

@@ -49,9 +49,9 @@
    def test_compile_global_nn_mod(self):
        with torch.no_grad():
            trt_mod = torchtrt.compile(self.model,
-                                   inputs=[self.input],
-                                   device=torchtrt.Device(gpu_id=0),
-                                   enabled_precisions={torch.float})
+                                       inputs=[self.input],
+                                       device=torchtrt.Device(gpu_id=0),
+                                       enabled_precisions={torch.float})
            same = (trt_mod(self.input) - self.scripted_model(self.input)).abs().max()
            self.assertTrue(same < 2e-2)

Reformatting /workspace/tests/py/model_test_case.py
Reformatting /workspace/tests/py/test_api_dla.py
Reformatting /workspace/tests/py/test_api.py
Reformatting /workspace/tests/py/test_ptq_trt_calibrator.py
Reformatting /workspace/tests/py/test_ptq_to_backend.py
Reformatting /workspace/tests/py/test_ptq_dataloader_calibrator.py
Reformatting /workspace/tests/py/test_qat_trt_accuracy.py
Reformatting /workspace/tests/py/test_trt_intercompatability.py
Reformatting /workspace/tests/py/test_to_backend_api.py
Reformatting /workspace/tests/py/test_multi_gpu.py
Reformatting /workspace/tests/modules/hub.py
ERROR: Some files do not conform to style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /workspace/tests/py/test_api.py	(original)
+++ /workspace/tests/py/test_api.py	(reformatted)
@@ -32,9 +32,9 @@
    def test_compile_script(self):
        with torch.no_grad():
            trt_mod = torchtrt.ts.compile(self.scripted_model,
-                                      inputs=[self.input],
-                                      device=torchtrt.Device(gpu_id=0),
-                                      enabled_precisions={torch.float})
+                                          inputs=[self.input],
+                                          device=torchtrt.Device(gpu_id=0),
+                                          enabled_precisions={torch.float})
            same = (trt_mod(self.input) - self.scripted_model(self.input)).abs().max()
            self.assertTrue(same < 2e-2)

@@ -49,9 +49,9 @@
    def test_compile_global_nn_mod(self):
        with torch.no_grad():
            trt_mod = torchtrt.compile(self.model,
-                                   inputs=[self.input],
-                                   device=torchtrt.Device(gpu_id=0),
-                                   enabled_precisions={torch.float})
+                                       inputs=[self.input],
+                                       device=torchtrt.Device(gpu_id=0),
+                                       enabled_precisions={torch.float})
            same = (trt_mod(self.input) - self.scripted_model(self.input)).abs().max()
            self.assertTrue(same < 2e-2)

Reformatting /workspace/tests/py/model_test_case.py
Reformatting /workspace/tests/py/test_api_dla.py
Reformatting /workspace/tests/py/test_api.py
Reformatting /workspace/tests/py/test_ptq_trt_calibrator.py
Reformatting /workspace/tests/py/test_ptq_to_backend.py
Reformatting /workspace/tests/py/test_ptq_dataloader_calibrator.py
Reformatting /workspace/tests/py/test_qat_trt_accuracy.py
Reformatting /workspace/tests/py/test_trt_intercompatability.py
Reformatting /workspace/tests/py/test_to_backend_api.py
Reformatting /workspace/tests/py/test_multi_gpu.py
Reformatting /workspace/tests/modules/hub.py
ERROR: Some files do not conform to style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you sign your commit?

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This PR has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@ncomly-nvidia
Copy link
Contributor Author

@narendasan the commit is signed I believe? Seems doing so from web is an issue..

@narendasan
Copy link
Collaborator

Seems like the issue is the emails dont match

Commit sha: bc3d29b, Author: Nick Comly, Committer: GitHub; Expected "Nick Comly [email protected]", but got "Nick Comly [email protected]".

@narendasan
Copy link
Collaborator

Testing to see if this triggers DCO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants