Skip to content

refactor: Added a py lint to address PR failures #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Dec 6, 2021

Signed-off-by: Anurag Dixit [email protected]

Description

Currently, different PRs are reporting failures for linting. Fixing this in NGC branch.
Analogous to PR 753

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@andi4191 andi4191 added the NGC PRs targeted at NGC release branches label Dec 6, 2021
@andi4191 andi4191 requested a review from narendasan December 6, 2021 17:57
@andi4191 andi4191 self-assigned this Dec 6, 2021
@github-actions github-actions bot added the component: tests Issues re: Tests label Dec 6, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@andi4191 andi4191 requested a review from peri044 December 9, 2021 04:46
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@peri044 peri044 merged commit 77d0eed into release/ngc/22.01 Dec 10, 2021
@andi4191 andi4191 deleted the anuragd/pylint_ngc branch February 24, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests Issues re: Tests NGC PRs targeted at NGC release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants