Skip to content

Fix the bug that fallback does not support more than one output #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

cyfwry
Copy link
Contributor

@cyfwry cyfwry commented Jan 19, 2022

Signed-off-by: liangtao07 [email protected]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #811

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@narendasan narendasan requested a review from peri044 January 19, 2022 22:44
@narendasan
Copy link
Collaborator

cc @inocsin

Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyfwry
Copy link
Contributor Author

cyfwry commented Jan 25, 2022

I have ran run_cpp_linter.py locally and modify the code format.

@narendasan narendasan merged commit 726b031 into pytorch:master Jan 31, 2022
@cyfwry cyfwry deleted the 811 branch February 16, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Fallback models with multiple outputs and encounter bug during inference
3 participants