fix(aten::neg): Fix a index bug in neg #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
frank-wei
pushed a commit
that referenced
this pull request
Jun 4, 2022
Summary: Pull Request resolved: https://github.com/pytorch/fx2trt/pull/86 1. delete dead code should be used cautiously. We need to keep the other inplace op for future optimization pass. 2. add support for type 3. disable isinf converter since the implementation will generate inaccurate results in hf_T5 model. The reason is not very clear 4. disable embedding converter for a few reasons 1) embedding in hf models are all int64 indices which will skip this op anyway 2)if the indices are constant node, it should throw error and this whole subgraph will fall back to non-TRT. So it is better uncommented and leave it to future. hf models in torchbench are summarized below. 3 models do not work well for TRT with speedup close 1x since major subgraph fall back to non-TRT. Reviewed By: 842974287 Differential Revision: D36731186 fbshipit-source-id: 8f56fb875419b9a3f03432f0ef5c00fdfc6b6741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an index issue with neg
Type of change
Checklist:
make htmlin docsrc)