Skip to content

Add CitriNet Notebook #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

mengdih
Copy link
Contributor

@mengdih mengdih commented Feb 24, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@narendasan
Copy link
Collaborator

Notebook looks good, can you add it to the index in the documentation? https://github.com/NVIDIA/Torch-TensorRT/blob/master/docsrc/index.rst

@narendasan
Copy link
Collaborator

Also @mengdih please sign your commits

Signed-off-by: Mengdi Huang <[email protected]>
@mengdih mengdih force-pushed the mengdih-citrinet-nb branch from 5cf758e to d7edb7b Compare March 2, 2022 21:08
@narendasan
Copy link
Collaborator

narendasan commented Mar 2, 2022

I think you need to squash these commits into one, DCO is still complaining about the original commit. Every commit needs to be signed. https://github.com/NVIDIA/Torch-TensorRT/pull/897/checks?check_run_id=5398369424

@vinhngx
Copy link
Contributor

vinhngx commented Mar 2, 2022

This branch is very outdated. "This branch is 2 commits ahead, 1491 commits behind NVIDIA:master."
I suggest forking an up to date master branch, then add the new notebook, also make change to README file, then make another PR.

@narendasan
Copy link
Collaborator

narendasan commented Mar 28, 2022

Bump on this PR @mengdih @vinhngx, still need the commits to be signed

@vinhngx
Copy link
Contributor

vinhngx commented Apr 19, 2022

Alternative MR submitted: #984
Pls kindly close this request @narendasan .

@narendasan narendasan closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants