feat: Add converter files for torch::max #934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peri044
requested changes
Mar 18, 2022
| } | ||
| uint32_t shiftDim = 1 << dim; | ||
|
|
||
| auto TopKOperation = largest ? (nvinfer1::TopKOperation::kMAX) : (nvinfer1::TopKOperation::kMIN); |
There was a problem hiding this comment.
you can remove auto largest = true and change this line to auto TopKOperation = largest ? (nvinfer1::TopKOperation::kMAX) since we are only using max always here
p517332051
commented
Mar 19, 2022
p517332051
force-pushed
the
Netease-Torch-TensorRT
branch
from
9ee9f86 to
a1880d4
Compare
|
Please sign your commits so that DCO passes |
p517332051
force-pushed
the
Netease-Torch-TensorRT
branch
from
a1880d4 to
62b6d05
Compare
get |
Signed-off-by: hongwei03 <[email protected]>
Signed-off-by: hongwei03 <[email protected]>
Signed-off-by: hongwei03 <[email protected]>
p517332051
force-pushed
the
Netease-Torch-TensorRT
branch
from
81db792 to
0b5673b
Compare
Signed-off-by: hongwei03 <[email protected]>
|
We still need a test case for this operator to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is new feature,that add support for torch::max operator, the mainly implemented by using the topk of tensorrt.
Type of change
Checklist: