Skip to content

Fixes for CI pipeline pre-cxx11 pipeline #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2022
Merged

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Apr 21, 2022

Description

Added fixes required for CI pipeline

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@andi4191 andi4191 self-assigned this Apr 21, 2022
@andi4191
Copy link
Contributor Author

/nvidia-ci

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: tests Issues re: Tests labels Apr 21, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/core/lowering/register_trt_placeholder_ops.cpp b/tmp/changes.txt
index 5ba8171..17d7d3f 100644
--- a/workspace/core/lowering/register_trt_placeholder_ops.cpp
+++ b/tmp/changes.txt
@@ -10,7 +10,10 @@ c10::AliasAnalysisKind aliasAnalysisFromSchema() {
RegisterOperators trt_placeholder_ops_reg({
    /// Op marks a Tensor to be conveted from an Torch Tensor
    /// to a TRT constant Tensor
-    Operator("trt::const(Tensor val) -> Tensor", [](Stack& stack) { /*noop*/ }, aliasAnalysisFromSchema()),
+    Operator(
+        "trt::const(Tensor val) -> Tensor",
+        [](Stack& stack) { /*noop*/ },
+        aliasAnalysisFromSchema()),
});

} // namespace jit
ERROR: Some files do not conform to style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@andi4191
Copy link
Contributor Author

/nvidia-ci

16 similar comments
@andi4191
Copy link
Contributor Author

/nvidia-ci

@andi4191
Copy link
Contributor Author

/nvidia-ci

@andi4191
Copy link
Contributor Author

/nvidia-ci

@andi4191
Copy link
Contributor Author

/nvidia-ci

@andi4191
Copy link
Contributor Author

/nvidia-ci

@andi4191
Copy link
Contributor Author

/nvidia-ci

@andi4191
Copy link
Contributor Author

/nvidia-ci

@narendasan
Copy link
Collaborator

/nvidia-ci

@narendasan
Copy link
Collaborator

/nvidia-ci

@narendasan
Copy link
Collaborator

/nvidia-ci

@narendasan
Copy link
Collaborator

/nvidia-ci

@narendasan
Copy link
Collaborator

/nvidia-ci

@narendasan
Copy link
Collaborator

/nvidia-ci

@narendasan
Copy link
Collaborator

/nvidia-ci

@narendasan
Copy link
Collaborator

/nvidia-ci

@narendasan
Copy link
Collaborator

/nvidia-ci

@narendasan
Copy link
Collaborator

/blossom-ci

4 similar comments
@narendasan
Copy link
Collaborator

/blossom-ci

@andi4191
Copy link
Contributor Author

/blossom-ci

@andi4191
Copy link
Contributor Author

/blossom-ci

@andi4191
Copy link
Contributor Author

/blossom-ci

@github-actions
Copy link

👎 Promotion blocked, new vulnerability found

Vulnerability report

Component Vulnerability Description Severity
The FreeType Project CVE-2020-15999 Heap buffer overflow in Freetype in Google Chrome prior to 86.0.4240.111 allowed a remote attacker to potentially exploit heap corruption via a crafted HTML page. MEDIUM

@andi4191
Copy link
Contributor Author

/blossom-ci

1 similar comment
@andi4191
Copy link
Contributor Author

/blossom-ci

@github-actions
Copy link

👎 Promotion blocked, new vulnerability found

Vulnerability report

Component Vulnerability Description Severity
The FreeType Project CVE-2020-15999 Heap buffer overflow in Freetype in Google Chrome prior to 86.0.4240.111 allowed a remote attacker to potentially exploit heap corruption via a crafted HTML page. MEDIUM

@andi4191
Copy link
Contributor Author

/blossom-ci

1 similar comment
@andi4191
Copy link
Contributor Author

/blossom-ci

@github-actions
Copy link

👎 Promotion blocked, new vulnerability found

Vulnerability report

Component Vulnerability Description Severity
The FreeType Project CVE-2020-15999 Heap buffer overflow in Freetype in Google Chrome prior to 86.0.4240.111 allowed a remote attacker to potentially exploit heap corruption via a crafted HTML page. MEDIUM

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/core/lowering/register_trt_placeholder_ops.cpp b/tmp/changes.txt
index 5ba8171..17d7d3f 100644
--- a/workspace/core/lowering/register_trt_placeholder_ops.cpp
+++ b/tmp/changes.txt
@@ -10,7 +10,10 @@ c10::AliasAnalysisKind aliasAnalysisFromSchema() {
RegisterOperators trt_placeholder_ops_reg({
    /// Op marks a Tensor to be conveted from an Torch Tensor
    /// to a TRT constant Tensor
-    Operator("trt::const(Tensor val) -> Tensor", [](Stack& stack) { /*noop*/ }, aliasAnalysisFromSchema()),
+    Operator(
+        "trt::const(Tensor val) -> Tensor",
+        [](Stack& stack) { /*noop*/ },
+        aliasAnalysisFromSchema()),
});

} // namespace jit
ERROR: Some files do not conform to style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@andi4191 andi4191 force-pushed the anuragd/ci_fixes branch from d0f6a83 to 962660d Compare May 2, 2022 22:28
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@andi4191 andi4191 changed the title WIP: Fixes for CI pipeline pre-cxx11 pipeline Fixes for CI pipeline pre-cxx11 pipeline May 4, 2022
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit ce1d112 into master May 4, 2022
@andi4191 andi4191 deleted the anuragd/ci_fixes branch August 10, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: api [Python] Issues re: Python API component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants