Grant runners write access to S3 ossci-benchmarks bucket #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydhn
requested review from
jeanschmidt,
zxiiro and
ZainRizvi
as code owners
huydhn
force-pushed
the
grant-runner-permission-benchmark-bucket
branch
from
b9d902a to
92045ba
Compare
zxiiro
approved these changes
Nov 14, 2024
ZainRizvi
approved these changes
Nov 14, 2024
|
@huydhn FYI I just ran the deployment job for this. The change should be live shortly. |
|
Thank you! I guess this is the on https://github.com/pytorch/ci-infra/actions/runs/11842757366 |
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSIA, this grants the runner the permission to upload benchmark results to this bucket. Once there, the results will be propagated to ClickHouse.
The other PR on pytorch-gha-infra https://github.com/pytorch-labs/pytorch-gha-infra/pull/533. I assume that I need to have this one to grant the permission to LF runners, plz correct me if that's not the case.