Skip to content

[2D] Update 2d example to use get_local_rank #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented Dec 8, 2023

We now have a new DeviceMesh API get_local_rank so users would no longer need to get the underlying pg and then get the local rank from it.

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit 7158eef
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/657388836527b4000827e34a

@wz337 wz337 force-pushed the update_2d_example branch from b5771e2 to 7158eef Compare December 8, 2023 21:20
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this new api is much cleaner.
lgtm!

@lessw2020 lessw2020 merged commit 30b310a into pytorch:main Dec 8, 2023
YinZhengxun pushed a commit to YinZhengxun/mt-exercise-02 that referenced this pull request Mar 30, 2025
update 2d example to use get_local_rank
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants