Skip to content

Commit 2fc99b0

Browse files
huydhnfacebook-github-bot
authored andcommitted
Forward fix macOS job after test-infra #5086 (#2980)
Summary: After pytorch/test-infra#5086, the working directory is now set correctly, so `pushd` isn't needed anymore. More importantly, trying to change the directory ends up failing all macOS CI jobs because that subdirectory doesn't exist. Pull Request resolved: #2980 Reviewed By: larryliu0820 Differential Revision: D55996299 Pulled By: huydhn fbshipit-source-id: 05758603d7628cc0a01fd577a49202d45c84e6c5
1 parent 75c27c3 commit 2fc99b0

File tree

3 files changed

+0
-35
lines changed

3 files changed

+0
-35
lines changed

.github/workflows/_unittest.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,6 @@ jobs:
5757
script: |
5858
set -eux
5959
60-
WORKSPACE=$(pwd)
61-
pushd "${WORKSPACE}/pytorch/executorch"
62-
6360
BUILD_TOOL=${{ matrix.build-tool }}
6461
6562
bash .ci/scripts/setup-conda.sh
@@ -75,5 +72,3 @@ jobs:
7572
${CONDA_RUN} pytest -n auto --cov=./ --cov-report=xml
7673
# Run gtest
7774
${CONDA_RUN} buck2 test runtime/core/... runtime/platform/...
78-
79-
popd

.github/workflows/apple.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ jobs:
3434
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
3535
timeout: 90
3636
script: |
37-
WORKSPACE=$(pwd)
38-
pushd "${WORKSPACE}/pytorch/executorch"
3937
BUILD_TOOL=cmake
4038
4139
.ci/scripts/setup-conda.sh
@@ -48,8 +46,6 @@ jobs:
4846
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \
4947
build/test_ios_ci.sh
5048
51-
popd
52-
5349
build-frameworks-ios:
5450
name: build-frameworks-ios
5551
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
@@ -61,8 +57,6 @@ jobs:
6157
upload-artifact: executorch-frameworks-ios
6258
timeout: 90
6359
script: |
64-
WORKSPACE=$(pwd)
65-
pushd "${WORKSPACE}/pytorch/executorch"
6660
BUILD_TOOL=cmake
6761
VERSION="0.1.0"
6862
FRAMEWORKS=(
@@ -111,8 +105,6 @@ jobs:
111105
zip -r "${RUNNER_TEMP}/artifacts/${FRAMEWORK}_debug-${VERSION}.zip" "${FRAMEWORK}_debug.xcframework"
112106
) done
113107
114-
popd
115-
116108
upload-frameworks-ios:
117109
runs-on: ubuntu-22.04
118110
needs: build-frameworks-ios

.github/workflows/trunk.yml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ jobs:
4646
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
4747
timeout: ${{ matrix.timeout }}
4848
script: |
49-
WORKSPACE=$(pwd)
50-
pushd "${WORKSPACE}/pytorch/executorch"
51-
5249
MODEL_NAME=${{ matrix.model }}
5350
BUILD_TOOL=${{ matrix.build-tool }}
5451
BACKEND=${{ matrix.backend }}
@@ -59,7 +56,6 @@ jobs:
5956
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh "${BUILD_TOOL}"
6057
# Build and test xecutorch
6158
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/test.sh "${MODEL_NAME}" "${BUILD_TOOL}" "${BACKEND}" "${DEMO_BACKEND_DELEGATION}"
62-
popd
6359
6460
test-custom-ops-macos:
6561
name: test-custom-ops-macos
@@ -75,17 +71,13 @@ jobs:
7571
submodules: 'true'
7672
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
7773
script: |
78-
WORKSPACE=$(pwd)
79-
pushd "${WORKSPACE}/pytorch/executorch"
80-
8174
BUILD_TOOL=${{ matrix.build-tool }}
8275
8376
bash .ci/scripts/setup-conda.sh
8477
# Setup MacOS dependencies as there is no Docker support on MacOS atm
8578
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh "${BUILD_TOOL}"
8679
# Build and test custom ops
8780
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash examples/portable/custom_ops/test_custom_ops.sh "${BUILD_TOOL}"
88-
popd
8981
9082
test-selective-build-macos:
9183
name: test-selective-build-macos
@@ -101,17 +93,13 @@ jobs:
10193
submodules: 'true'
10294
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
10395
script: |
104-
WORKSPACE=$(pwd)
105-
pushd "${WORKSPACE}/pytorch/executorch"
106-
10796
BUILD_TOOL=${{ matrix.build-tool }}
10897
10998
bash .ci/scripts/setup-conda.sh
11099
# Setup MacOS dependencies as there is no Docker support on MacOS atm
111100
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh "${BUILD_TOOL}"
112101
# Build and test selective build
113102
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash examples/selective_build/test_selective_build.sh "${BUILD_TOOL}"
114-
popd
115103
116104
test-demo-backend-delegation:
117105
name: test-demo-backend-delegation
@@ -208,17 +196,13 @@ jobs:
208196
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
209197
timeout: 90
210198
script: |
211-
WORKSPACE=$(pwd)
212-
pushd "${WORKSPACE}/pytorch/executorch"
213-
214199
BUILD_TOOL=cmake
215200
216201
bash .ci/scripts/setup-conda.sh
217202
# Setup MacOS dependencies as there is no Docker support on MacOS atm
218203
GITHUB_RUNNER=1 PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh "${BUILD_TOOL}"
219204
# Build and test coreml delegate
220205
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash backends/apple/coreml/scripts/build_all.sh
221-
popd
222206
223207
test-pybind-build-macos:
224208
name: test-pybind-build-macos
@@ -235,8 +219,6 @@ jobs:
235219
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
236220
timeout: 180
237221
script: |
238-
WORKSPACE=$(pwd)
239-
pushd "${WORKSPACE}/pytorch/executorch"
240222
bash .ci/scripts/setup-conda.sh
241223
242224
# build module for executorch.extension.pybindings.portable_lib
@@ -245,7 +227,6 @@ jobs:
245227
246228
# see if we can import the module successfully
247229
${CONDA_RUN} python -c "from executorch.extension.pybindings import portable_lib; print('success!')"
248-
popd
249230
250231
test-llama-runner-macos:
251232
name: test-llama-runner-mac
@@ -263,8 +244,6 @@ jobs:
263244
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
264245
timeout: 900
265246
script: |
266-
WORKSPACE=$(pwd)
267-
pushd "${WORKSPACE}/pytorch/executorch"
268247
bash .ci/scripts/setup-conda.sh
269248
270249
DTYPE=${{ matrix.dtype }}
@@ -278,4 +257,3 @@ jobs:
278257
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash examples/models/llama2/install_requirements.sh
279258
# Test llama2
280259
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/test_llama.sh stories110M.pt "${BUILD_TOOL}" "${DTYPE}" "${MODE}"
281-
popd

0 commit comments

Comments
 (0)