Skip to content

Commit 306f06f

Browse files
kirklandsignfacebook-github-bot
authored andcommitted
Linux OSS CI use cmake built gtest (#3609)
Summary: We are deprecating buck2 support in OSS. Migrate unit tests to cmake and run them in CI. Pull Request resolved: #3609 Test Plan: CI https://github.com/pytorch/executorch/actions/runs/9198444538/job/25301231796?pr=3609 Reviewed By: huydhn Differential Revision: D57693481 Pulled By: kirklandsign fbshipit-source-id: 4d31f07695d2162a58cd6267029ecfbe76b03cbe
1 parent 2d48cdc commit 306f06f

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

.github/workflows/_unittest.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ on:
1515
jobs:
1616
linux:
1717
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
18-
strategy:
19-
matrix:
20-
include:
21-
- build-tool: buck2
2218
with:
2319
runner: linux.2xlarge
2420
docker-image: ${{ inputs.docker-image }}
@@ -32,16 +28,16 @@ jobs:
3228
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
3329
conda activate "${CONDA_ENV}"
3430
35-
BUILD_TOOL=${{ matrix.build-tool }}
36-
3731
# Setup MacOS dependencies as there is no Docker support on MacOS atm
3832
PYTHON_EXECUTABLE=python \
3933
EXECUTORCH_BUILD_PYBIND=ON \
4034
CMAKE_ARGS="-DEXECUTORCH_BUILD_XNNPACK=ON -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON" \
41-
.ci/scripts/setup-linux.sh "${BUILD_TOOL}"
35+
.ci/scripts/setup-linux.sh cmake
4236
4337
# Run pytest with coverage
4438
pytest -n auto --cov=./ --cov-report=xml
39+
# Run gtest
40+
test/run_oss_cpp_tests.sh
4541
4642
macos:
4743
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main

test/run_oss_cpp_tests.sh

100644100755
File mode changed.

0 commit comments

Comments
 (0)