Linux OSS CI use cmake built gtest #3609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3609
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3fbd9e2 with merge base 0dc9488 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
force-pushed
the
oss-cpp-test
branch
2 times, most recently
from
d58b28f to
135958b
Compare
kirklandsign
force-pushed
the
oss-cpp-test
branch
from
135958b to
3e41ee0
Compare
For OSS, we should focus on CMake build. Now we can build c++ tests, we should run them with cmake built tests. Enable linux first.
kirklandsign
force-pushed
the
oss-cpp-test
branch
from
3e41ee0 to
125bfa5
Compare
kirklandsign
changed the title
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
huydhn
approved these changes
May 22, 2024
|
@kirklandsign merged this pull request in 306f06f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are deprecating buck2 support in OSS. Migrate unit tests to cmake and run them in CI.