Skip to content

Commit 31e5105

Browse files
larryliu0820facebook-github-bot
authored andcommitted
Remove remaining reference to torchgen.gen_executorch (#11290)
Summary: Fixes #11232 This is part of an effort to remove ExecuTorch related codegen code in pytorch/pytorch's torchgen module. We need to remove `torchgen.gen_executorch` in ExecuTorch and use `executorch.codegen.gen` instead. Differential Revision: D75800153
1 parent 311489f commit 31e5105

File tree

4 files changed

+7
-18
lines changed

4 files changed

+7
-18
lines changed

codegen/test/test_executorch_custom_ops.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515

1616
import torchgen
1717
from executorch.codegen.api.custom_ops import ComputeNativeFunctionStub
18+
from executorch.codegen.gen import gen_headers
1819
from executorch.codegen.model import ETKernelIndex
19-
from torchgen.gen_executorch import gen_headers
2020
from torchgen.model import Location, NativeFunction
2121
from torchgen.selective_build.selector import SelectiveBuilder
2222
from torchgen.utils import FileManager

codegen/test/test_executorch_gen.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
import unittest
1212

1313
import yaml
14-
15-
from executorch.codegen.model import ETKernelIndex, ETKernelKey
16-
from torchgen.gen import LineLoader
17-
from torchgen.gen_executorch import (
14+
from executorch.codegen.gen import (
1815
ComputeCodegenUnboxedKernels,
1916
gen_functions_declarations,
2017
parse_yaml_files,
2118
translate_native_yaml,
2219
)
20+
21+
from executorch.codegen.model import ETKernelIndex, ETKernelKey
22+
from torchgen.gen import LineLoader
2323
from torchgen.model import (
2424
BackendIndex,
2525
BackendMetadata,

third-party/TARGETS

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -81,18 +81,6 @@ runtime.python_binary(
8181
_is_external_target = True,
8282
)
8383

84-
runtime.python_binary(
85-
name = "gen_executorch",
86-
main_module = "torchgen.gen_executorch",
87-
visibility = [
88-
"PUBLIC",
89-
],
90-
deps = [
91-
":torchgen",
92-
],
93-
_is_external_target = True,
94-
)
95-
9684
runtime.filegroup(
9785
name = "aten_src_path",
9886
srcs = [

tools/cmake/Codegen.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,9 @@ function(generate_bindings_for_kernels)
9191
OUTPUT_STRIP_TRAILING_WHITESPACE
9292
)
9393
file(GLOB_RECURSE _torchgen_srcs "${torchgen-out}/*.py")
94+
# Not using module executorch.codegen.gen because it's not installed yet.
9495
set(_gen_command
95-
"${PYTHON_EXECUTABLE}" -m torchgen.gen_executorch
96+
"${PYTHON_EXECUTABLE}" ${EXECUTORCH_ROOT}/codegen/gen.py
9697
--source-path=${EXECUTORCH_ROOT}/codegen --install-dir=${_out_dir}
9798
--tags-path=${torchgen-out}/packaged/ATen/native/tags.yaml
9899
--aten-yaml-path=${torchgen-out}/packaged/ATen/native/native_functions.yaml

0 commit comments

Comments
 (0)