Remove remaining reference to torchgen.gen_executorch #11290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryliu0820
requested review from
jathu,
kirklandsign,
lucylq and
GregoryComer
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11290
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 2 Unrelated FailuresAs of commit b33c194 with merge base 8e2737c ( CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75800153 |
larryliu0820
added
the
release notes: none
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
Summary: Fixes #11232 This is part of an effort to remove ExecuTorch related codegen code in pytorch/pytorch's torchgen module. We need to remove `torchgen.gen_executorch` in ExecuTorch and use `executorch.codegen.gen` instead. Differential Revision: D75800153
facebook-github-bot
force-pushed
the
export-D75800153
branch
from
82355ef to
31e5105
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75800153 |
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Fixes #11232 This is part of an effort to remove ExecuTorch related codegen code in pytorch/pytorch's torchgen module. We need to remove `torchgen.gen_executorch` in ExecuTorch and use `executorch.codegen.gen` instead. Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Differential Revision: D75800153 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
export-D75800153
branch
from
1c3c234 to
b33c194
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75800153 |
lucylq
approved these changes
Jun 3, 2025
| from executorch.codegen.model import ETKernelIndex, ETKernelKey, ETParsedYaml | ||
| from executorch.codegen.parse import ET_FIELDS, parse_et_yaml, parse_et_yaml_struct | ||
| except ImportError: | ||
| # If we build from source, executorch.codegen is not available. |
There was a problem hiding this comment.
noob q: why is this the case?
There was a problem hiding this comment.
To build ET from source we need selective build and generated bindings. So these scripts will be called before they are being installed into site-packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #11232
This is part of an effort to remove ExecuTorch related codegen code in pytorch/pytorch's torchgen module. We need to remove
torchgen.gen_executorchin ExecuTorch and useexecutorch.codegen.geninstead.Differential Revision: D75800153