Skip to content

Commit 32a5926

Browse files
larryliu0820facebook-github-bot
authored andcommitted
Remove -s compile option from release mode (#3367)
Summary: This compile option causes a lot of warnings in cmake build: ``` clang: warning: argument unused during compilation: '-s' [-Wunused-command-line-argument] ``` So removing it for now. Pull Request resolved: #3367 Reviewed By: dbort Differential Revision: D56617190 Pulled By: larryliu0820 fbshipit-source-id: 950a122b55deb5d5d3c15d0e46745b6697c8f7ba
1 parent c992983 commit 32a5926

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ endif()
120120
# disables exceptions and runtime type.
121121
set(CMAKE_CXX_FLAGS_RELEASE
122122
"-ffunction-sections -fdata-sections -fno-exceptions -fno-rtti")
123-
if(NOT APPLE)
123+
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
124124
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -s")
125125
endif()
126126

0 commit comments

Comments
 (0)