Remove -s compile option from release mode #3367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This compile option causes a lot of warnings in cmake build: ``` clang: warning: argument unused during compilation: '-s' [-Wunused-command-line-argument] ``` So removing it for now. Test Plan: Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3367
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 67ed43c with merge base 7b3f5c6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dbort
approved these changes
Apr 29, 2024
|
@larryliu0820 merged this pull request in 32a5926. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This compile option causes a lot of warnings in cmake build:
So removing it for now.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: