Skip to content

Commit 34f093e

Browse files
committed
Use external_deps for sentencepiece
Pull Request resolved: #4269 as title ghstack-source-id: 234090425 Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/)
1 parent 0cde6b8 commit 34f093e

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

extension/llm/tokenizer/targets.bzl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ def define_common_targets():
2020
"//bento_kernels/...",
2121
],
2222
_is_external_target = True,
23-
# TODO: Define an external_deps entry for sentencepiece instead of pointing to an fbsource path.
24-
deps = [] if runtime.is_oss else ["fbsource//third-party/pypi/sentencepiece:sentencepiece"],
23+
external_deps = [
24+
"sentencepiece-py",
25+
],
2526
)
2627

2728
runtime.python_binary(

shim/xplat/executorch/build/env_interface.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ _EXTERNAL_DEPS = {
4242
"prettytable": "//third-party:prettytable",
4343
"pybind11": "//third-party:pybind11",
4444
"re2": [], # TODO(larryliu0820): Add support
45+
"sentencepiece-py": [],
4546
# Core C++ PyTorch functionality like Tensor and ScalarType.
4647
"torch-core-cpp": "//third-party:libtorch",
4748
"torchgen": "//third-party:torchgen",

0 commit comments

Comments
 (0)