Skip to content

Commit 377c750

Browse files
huydhnfacebook-github-bot
authored andcommitted
Use the pinned buck2 version on MacOS (#3726)
Summary: This should allow different BUCk2 version on main and on release branch Pull Request resolved: #3726 Reviewed By: kirklandsign Differential Revision: D57748728 Pulled By: huydhn fbshipit-source-id: a376777c30051aa286ac92b11c5421ee6d28f7c9
1 parent c4c165b commit 377c750

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

.ci/scripts/setup-macos.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,18 @@ install_buck() {
2828
fi
2929

3030
pushd .ci/docker
31-
3231
# TODO(huydo): This is a one-off copy of buck2 2024-05-15 to unblock Jon and
3332
# re-enable ShipIt. It’s not ideal that upgrading buck2 will require a manual
3433
# update the cached binary on S3 bucket too. Let me figure out if there is a
3534
# way to correctly implement the previous setup of installing a new version of
3635
# buck2 only when it’s needed. AFAIK, the complicated part was that buck2
3736
# --version doesn't say anything w.r.t its release version, i.e. 2024-05-15.
3837
# See D53878006 for more details.
39-
BUCK2=buck2-aarch64-apple-darwin.zst
38+
#
39+
# If you need to upgrade buck2 version on S3, please reach out to Dev Infra
40+
# team for help.
41+
BUCK2_VERSION=$(cat ci_commit_pins/buck2.txt)
42+
BUCK2=buck2-aarch64-apple-darwin-${BUCK2_VERSION}.zst
4043
curl -s "https://ossci-macos.s3.amazonaws.com/${BUCK2}" -o "${BUCK2}"
4144

4245
zstd -d "${BUCK2}" -o buck2

0 commit comments

Comments
 (0)