Skip to content

Use the pinned buck2 version on MacOS #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Use the pinned buck2 version on MacOS #3726

wants to merge 4 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented May 23, 2024

This should allow different BUCk2 version on main and on release branch

@huydhn huydhn requested a review from kirklandsign May 23, 2024 21:52
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3726

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a06cc40 with merge base 1991346 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2024
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

dbort
dbort reviewed May 23, 2024
View reviewed changes
.ci/scripts/setup-macos.sh
@@ -28,15 +28,8 @@ install_buck() {
fi

pushd .ci/docker

# TODO(huydo): This is a one-off copy of buck2 2024-05-15 to unblock Jon and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep a comment here explaining why this copy exists instead of getting in the way we get it for non-macos systems. I'd still consider it a TODO to remove this manually-managed copy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also important to let people know who to talk to when we need to upgrade the buck2 version and add a new copy to the S3 bucket

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in 377c750.

kirklandsign pushed a commit to kirklandsign/executorch that referenced this pull request May 24, 2024
@huydhn @kirklandsign
Use the pinned buck2 version on MacOS (pytorch#3726)
5ab0678 
Summary:
This should allow different BUCk2 version on main and on release branch

Pull Request resolved: pytorch#3726

Reviewed By: kirklandsign

Differential Revision: D57748728

Pulled By: huydhn

fbshipit-source-id: a376777c30051aa286ac92b11c5421ee6d28f7c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbort dbort dbort left review comments

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huydhn @facebook-github-bot @dbort @kirklandsign