Skip to content

Commit 87fdedd

Browse files
huydhnfacebook-github-bot
authored andcommitted
Fix broken unit tests and timeout for deeplabv3 (#425)
Summary: Some fixes to make trunk green again: * #349 rename a test. This is the quick mitigation, we will need a better test discovery mechanism here * Increase the timeout from 60m to 90m for deeplabv3. Again, this is also a quick fix. As this model will be the long pole on OSS CI. There are more powerful runner to use if that helps. Pull Request resolved: #425 Reviewed By: dbort Differential Revision: D49477725 Pulled By: huydhn fbshipit-source-id: 0fb701cd13ffd1eea76f630d4a1f8eb204e4c63f
1 parent 78f884f commit 87fdedd

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/workflows/pull.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
docker-image: executorch-ubuntu-22.04-clang12
4848
submodules: 'true'
4949
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
50-
timeout: 60
50+
timeout: 90
5151
script: |
5252
# The generic Linux job chooses to use base env, not the one setup by the image
5353
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
@@ -73,7 +73,7 @@ jobs:
7373
runner: macos-m1-12
7474
submodules: 'true'
7575
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
76-
timeout: 60
76+
timeout: 90
7777
script: |
7878
WORKSPACE=$(pwd)
7979
pushd "${WORKSPACE}/pytorch/executorch"

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ exir/_serialize/program.fbs
1111
bundled_program/serialize/bundled_program_schema.fbs
1212
bundled_program/serialize/scalar_type.fbs
1313

14-
# Any exported models
14+
# Any exported models and profiling outputs
1515
*.pte
16+
*.bin
1617

1718
# Editor temporaries
1819
*.swa

pytest.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ addopts =
3232
exir/tests/test_tensor.py
3333
exir/tests/test_quant_lowering_custom_backend_pass.py
3434
# kernels/
35-
kernels/prim_ops/test/test_prim_ops.py
35+
kernels/prim_ops/test/prim_ops_test.py
3636
kernels/test/test_case_gen.py
3737
# backends/tosa
3838
backends/tosa/test

0 commit comments

Comments
 (0)