Skip to content

Fix broken unit tests and timeout for deeplabv3 #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix broken unit tests and timeout for deeplabv3 #425

wants to merge 1 commit into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 20, 2023

Some fixes to make trunk green again:

  • update prim ops lib #349 rename a test. This is the quick mitigation, we will need a better test discovery mechanism here
  • Increase the timeout from 60m to 90m for deeplabv3. Again, this is also a quick fix. As this model will be the long pole on OSS CI. There are more powerful runner to use if that helps.

@huydhn huydhn requested a review from guangy10 September 20, 2023 21:46
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2023
@huydhn huydhn requested a review from dbort September 20, 2023 21:46
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in 87fdedd.

Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
@lucylq @malfet
create dir on download (#425)
d6da1b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guangy10 guangy10 Awaiting requested review from guangy10

@dbort dbort Awaiting requested review from dbort

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huydhn @facebook-github-bot