Skip to content

Commit 9b5876c

Browse files
committed
Only change the filename
1 parent eae3004 commit 9b5876c

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/android-perf.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ jobs:
111111
# so let's just sed it
112112
sed -i -e 's,{{ model_path }},'"${MODEL_PATH}"',g' android-llm-device-farm-test-spec.yml.j2
113113
114-
BENCHMARK_CONFIG_ID=$(echo "${{ matrix.model }}_${{ matrix.config }}" | sed -e 's/[^A-Za-z0-9._-]/_/g')
114+
BENCHMARK_CONFIG_ID="${{ matrix.model }}_${{ matrix.config }}"
115115
# The config for this benchmark runs, we save it in the test spec so that it can be fetched
116116
# later by the upload script
117117
sed -i -e 's,{{ benchmark_config_id }},'"${BENCHMARK_CONFIG_ID}"',g' android-llm-device-farm-test-spec.yml.j2
@@ -120,8 +120,9 @@ jobs:
120120
# Just print the test spec for debugging
121121
cat android-llm-device-farm-test-spec.yml
122122
123+
BENCHMARK_CONFIG_FILENAME=$(echo "${BENCHMARK_CONFIG_ID}" | sed -e 's/[^A-Za-z0-9._-]/_/g')
123124
# Save the benchmark configs so that we can use it later in the dashboard
124-
echo "${BENCHMARK_CONFIG}" > "${BENCHMARK_CONFIG_ID}.json"
125+
echo "${BENCHMARK_CONFIG}" > "${BENCHMARK_CONFIG_FILENAME}.json"
125126
126127
- name: Upload the spec
127128
uses: seemethere/upload-artifact-s3@v5

.github/workflows/apple-perf.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ jobs:
113113
# so let's just sed it
114114
sed -i -e 's,{{ model_path }},'"${MODEL_PATH}"',g' default-ios-device-farm-appium-test-spec.yml.j2
115115
116-
BENCHMARK_CONFIG_ID=$(echo "${{ matrix.model }}_${{ matrix.config }}" | sed -e 's/[^A-Za-z0-9._-]/_/g')
116+
BENCHMARK_CONFIG_ID="${{ matrix.model }}_${{ matrix.config }}"
117117
# The config for this benchmark runs, we save it in the test spec so that it can be fetched
118118
# later by the upload script
119119
sed -i -e 's,{{ benchmark_config_id }},'"${BENCHMARK_CONFIG_ID}"',g' default-ios-device-farm-appium-test-spec.yml.j2
@@ -122,8 +122,9 @@ jobs:
122122
# Just print the test spec for debugging
123123
cat default-ios-device-farm-appium-test-spec.yml
124124
125+
BENCHMARK_CONFIG_FILENAME=$(echo "${BENCHMARK_CONFIG_ID}" | sed -e 's/[^A-Za-z0-9._-]/_/g')
125126
# Save the benchmark configs so that we can use it later in the dashboard
126-
echo "${BENCHMARK_CONFIG}" > "${BENCHMARK_CONFIG_ID}.json"
127+
echo "${BENCHMARK_CONFIG}" > "${BENCHMARK_CONFIG_FILENAME}.json"
127128
128129
- name: Upload the spec
129130
uses: seemethere/upload-artifact-s3@v5

0 commit comments

Comments
 (0)