Skip to content

Commit a00d5ac

Browse files
Revert "Add (and fix) OSS check that et_operator_library dtype_select… (#11571)
…ive_build builds (#9245)" This reverts commit 7933ac9. ### Summary [PLEASE REMOVE] See [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests) for ExecuTorch PR guidelines. [PLEASE REMOVE] If this PR closes an issue, please add a `Fixes #<issue-id>` line. [PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: <area>" label. For a list of available release notes labels, check out [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests). ### Test plan [PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.
1 parent d719e8e commit a00d5ac

File tree

3 files changed

+2
-19
lines changed

3 files changed

+2
-19
lines changed

.ci/scripts/unittest-buck2.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ BUILDABLE_KERNELS_PRIM_OPS_TARGETS=$(buck2 query //kernels/prim_ops/... | grep -
2525
# //runtime/kernel/... is failing because //third-party:torchgen_files's shell script can't find python on PATH.
2626
# //runtime/test/... requires Python torch, which we don't have in our OSS buck setup.
2727
for op in "build" "test"; do
28-
buck2 $op $BUILDABLE_OPTIMIZED_OPS \
29-
//examples/selective_build:select_all_dtype_selective_lib_portable_lib \
30-
//kernels/portable/... \
28+
buck2 $op $BUILDABLE_OPTIMIZED_OPS //kernels/portable/... \
3129
$BUILDABLE_KERNELS_PRIM_OPS_TARGETS //runtime/backend/... //runtime/core/... \
3230
//runtime/executor: //runtime/kernel/... //runtime/platform/...
3331
done

examples/selective_build/targets.bzl

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,6 @@ def define_common_targets():
2525
],
2626
)
2727

28-
executorch_generated_lib(
29-
name = "select_all_dtype_selective_lib",
30-
functions_yaml_target = "//executorch/kernels/portable:functions.yaml",
31-
kernel_deps = [
32-
"//executorch/kernels/portable:operators",
33-
],
34-
# Setting dtype_selective_build without using list or dict selection isn't a
35-
# typical use case; we just do it here so that we can test that our mechanism
36-
# for getting buck deps right for dtype_selective_build is working.
37-
dtype_selective_build = True,
38-
deps = [
39-
":select_all_ops",
40-
],
41-
)
42-
4328
# Select a list of operators: defined in `ops`
4429
et_operator_library(
4530
name = "select_ops_in_list",

shim_et/xplat/executorch/codegen/codegen.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,7 @@ def executorch_generated_lib(
752752
See: https://www.internalfb.com/wiki/PyTorch/Teams/Edge/PyTorch_Edge_Core_Team/Dtype_Selective_Build/""")
753753

754754
if dtype_selective_build:
755-
if not expose_operator_symbols and not (is_xplat() or runtime.is_oss):
755+
if not expose_operator_symbols and not is_xplat():
756756
fail("""
757757
Dtype selective build with expose_operator_symbols=False works only in xplat -
758758
there are undefined symbols otherwise. Please try to use xplat, or talk to the

0 commit comments

Comments
 (0)