Add (and fix) OSS check that et_operator_library dtype_selective_build builds #9245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
swolchok
requested review from
manuelcandales,
lucylq,
larryliu0820 and
JacobSzwejbka
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9245
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 429a23f with merge base c6c3616 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
commented
Mar 13, 2025
| @@ -11,7 +11,7 @@ def define_common_targets(): | |||
| # build, where the portable ops are built from source and linked with :all_deps | |||
| runtime.cxx_library( | |||
| name = "all_deps", | |||
| deps = [ | |||
| exported_deps = [ | |||
There was a problem hiding this comment.
it's odd that this wasn't required internally
manuelcandales
approved these changes
Mar 27, 2025
|
test-apple-model failure looks non-flaky but unrelated; HUD confirms it's broken on trunk |
|
test-arm-backend doesn't use buck, should be a flake as well. rerunning failed jobs and importing to run internal CI just in case |
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Jun 11, 2025
|
thanks for adding this check :0 |
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…tive_build builds (#9245)" This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…tive_build builds (#9245)" This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) ghstack-source-id: 289775426 Pull Request resolved: #11573
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…dtype_selective_build builds (#9245)"" This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…tive_build builds (#9245)" Pull Request resolved: #11573 This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) ghstack-source-id: 289777137
JacobSzwejbka
added a commit
that referenced
this pull request
Jun 11, 2025
#11571) …ive_build builds (#9245)" This reverts commit 7933ac9. ### Summary [PLEASE REMOVE] See [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests) for ExecuTorch PR guidelines. [PLEASE REMOVE] If this PR closes an issue, please add a `Fixes #<issue-id>` line. [PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: <area>" label. For a list of available release notes labels, check out [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests). ### Test plan [PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…perator_library dtype_selective_build builds (#9245)"" This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…dtype_selective_build builds (#9245)"" This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…tive_build builds (#9245)" Pull Request resolved: #11573 This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. ghstack-source-id: 289810281 Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/)
JacobSzwejbka
pushed a commit
that referenced
this pull request
Jun 12, 2025
…tive_build builds (#9245)" (#11589) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11573 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/453/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/453/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/453/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check.