Reapply "Add (and fix) OSS check that et_operator_library dtype_selective_build builds (#9245)" #11573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive_build builds (#9245)" This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…tive_build builds (#9245)" This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) ghstack-source-id: 289775426 Pull Request resolved: #11573
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11573
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 3d29b17 with merge base cbd3874 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76458040 |
…dtype_selective_build builds (#9245)"" This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) [ghstack-poisoned]
swolchok
requested review from
lucylq,
larryliu0820 and
JacobSzwejbka
as code owners
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…tive_build builds (#9245)" Pull Request resolved: #11573 This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) ghstack-source-id: 289777137
JacobSzwejbka
approved these changes
Jun 11, 2025
|
failing jobs seem clearly unrelated |
…dtype_selective_build builds (#9245)"" This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 11, 2025
…tive_build builds (#9245)" Pull Request resolved: #11573 This was reverted due to internal CI failure; reapplying with that fixed (the new Buck target needed to be moved). Original summary: This wasn't checked, and it's easy to forget to update the all_deps targets if we don't check. Now we check. ghstack-source-id: 289810281 Differential Revision: [D76458040](https://our.internmc.facebook.com/intern/diff/D76458040/)
|
This pull request was exported from Phabricator. Differential Revision: D76458040 |
facebook-github-bot
merged commit f95bb30
into
gh/swolchok/453/base
192 of 193 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
JacobSzwejbka
pushed a commit
that referenced
this pull request
Jun 12, 2025
…tive_build builds (#9245)" (#11589) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11573 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/453/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/453/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/453/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This was reverted due to internal CI failure; reapplying with
that fixed (the new Buck target needed to be moved).
Original summary: This wasn't checked, and it's easy to forget to update the all_deps
targets if we don't check. Now we check.
Differential Revision: D76458040