Skip to content

Commit af441de

Browse files
zhxchen17facebook-github-bot
authored andcommitted
Removed deprecated dialect field from EP schema. [1/2] (#4254)
Summary: Pull Request resolved: #4254 As noted in the serialization schema, we've deprecated "dialect" field from EP and we're trying to remove it in this diff. Differential Revision: D59696447
1 parent dd7fa6a commit af441de

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

exir/serde/export_serialize.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1063,12 +1063,13 @@ def serialize(self, exported_program: ep.ExportedProgram) -> SerializedArtifact:
10631063
additional_kwargs["verifiers"] = [
10641064
v.dialect for v in exported_program.verifiers
10651065
]
1066+
elif hasattr(exported_program, "dialect"):
1067+
additional_kwargs["dialect"] = exported_program.dialect
10661068
serialized_ep = ExportedProgram(
10671069
graph_module=serialized_graph_module,
10681070
opset_version=self.opset_version,
10691071
range_constraints=serialized_range_constraints,
10701072
schema_version=SchemaVersion(-1, -1),
1071-
dialect=exported_program.dialect,
10721073
**additional_kwargs,
10731074
)
10741075

exir/serde/serialize.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -349,13 +349,14 @@ def serialize(
349349
additional_kwargs["verifiers"] = [
350350
v.dialect for v in exported_program.verifiers
351351
]
352+
elif hasattr(exported_program, "dialect"):
353+
additional_kwargs["dialect"] = exported_program.dialect
352354
return export_serialize.SerializedArtifact(
353355
schema.ExportedProgram(
354356
graph_module=serialized_graph_module,
355357
opset_version=self.opset_version,
356358
range_constraints=serialized_range_constraints,
357359
schema_version=SchemaVersion(-1, -1),
358-
dialect=exported_program.dialect,
359360
**additional_kwargs,
360361
),
361362
export_serialize.serialize_torch_artifact(exported_program.state_dict),
@@ -681,16 +682,24 @@ def deserialize(
681682

682683
dummy_g = torch.fx.Graph()
683684
dummy_g.output(())
685+
serialized_ep = serialized_artifact.exported_program
686+
additional_kwargs = {}
687+
if hasattr(serialized_ep, "verifiers"):
688+
additional_kwargs["verifiers"] = [
689+
load_verifier(v) for v in serialized_ep.verifiers # pyre-ignore
690+
]
691+
elif hasattr(serialized_ep, "dialect"):
692+
additional_kwargs["verifier"] = load_verifier(
693+
serialized_ep.dialect # pyre-ignore
694+
)
684695
exported_program = exir.ExportedProgram(
685696
root=state_dict,
686697
graph=dummy_g,
687698
graph_signature=ep.ExportGraphSignature(input_specs=[], output_specs=[]),
688699
state_dict=state_dict, # TODO(T157676982)
689700
range_constraints=range_constraints,
690701
module_call_graph=module_call_graph,
691-
verifier=load_verifier(
692-
serialized_artifact.exported_program.dialect # pyre-ignore
693-
),
702+
**additional_kwargs,
694703
)
695704
exported_program.graph_module.graph = graph_module.graph
696705
exported_program._graph_signature = res.signature

0 commit comments

Comments
 (0)