Removed deprecated dialect field from EP schema. #4254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4254
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit af441de with merge base dd7fa6a ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59696447 |
|
This pull request was exported from Phabricator. Differential Revision: D59696447 |
zhxchen17
force-pushed
the
export-D59696447
branch
from
f58a427 to
209c3a6
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Jul 15, 2024
Summary: X-link: pytorch/pytorch#130640 Pull Request resolved: pytorch#4254 As noted in the serialization schema, we've deprecated "dialect" field from EP and we're trying to remove it in this diff. Differential Revision: D59696447
|
This pull request was exported from Phabricator. Differential Revision: D59696447 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Jul 15, 2024
Summary: Pull Request resolved: pytorch#4254 As noted in the serialization schema, we've deprecated "dialect" field from EP and we're trying to remove it in this diff. Differential Revision: D59696447
zhxchen17
force-pushed
the
export-D59696447
branch
from
209c3a6 to
b3f2b26
Compare
Summary: Pull Request resolved: pytorch#4254 As noted in the serialization schema, we've deprecated "dialect" field from EP and we're trying to remove it in this diff. Differential Revision: D59696447
|
This pull request was exported from Phabricator. Differential Revision: D59696447 |
zhxchen17
force-pushed
the
export-D59696447
branch
from
b3f2b26 to
af441de
Compare
angelayi
approved these changes
Jul 15, 2024
|
This pull request has been merged in ac43606. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As noted in the serialization schema, we've deprecated "dialect" field from EP and we're trying to remove it in this diff.
Differential Revision: D59696447