Skip to content

Removed deprecated dialect field from EP schema. #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removed deprecated dialect field from EP schema. #4254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exir/serde/export_serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,12 +1063,13 @@ def serialize(self, exported_program: ep.ExportedProgram) -> SerializedArtifact:
additional_kwargs["verifiers"] = [
v.dialect for v in exported_program.verifiers
]
elif hasattr(exported_program, "dialect"):
additional_kwargs["dialect"] = exported_program.dialect
serialized_ep = ExportedProgram(
graph_module=serialized_graph_module,
opset_version=self.opset_version,
range_constraints=serialized_range_constraints,
schema_version=SchemaVersion(-1, -1),
dialect=exported_program.dialect,
**additional_kwargs,
)

Expand Down
17 changes: 13 additions & 4 deletions exir/serde/serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,13 +349,14 @@ def serialize(
additional_kwargs["verifiers"] = [
v.dialect for v in exported_program.verifiers
]
elif hasattr(exported_program, "dialect"):
additional_kwargs["dialect"] = exported_program.dialect
return export_serialize.SerializedArtifact(
schema.ExportedProgram(
graph_module=serialized_graph_module,
opset_version=self.opset_version,
range_constraints=serialized_range_constraints,
schema_version=SchemaVersion(-1, -1),
dialect=exported_program.dialect,
**additional_kwargs,
),
export_serialize.serialize_torch_artifact(exported_program.state_dict),
Expand Down Expand Up @@ -681,16 +682,24 @@ def deserialize(

dummy_g = torch.fx.Graph()
dummy_g.output(())
serialized_ep = serialized_artifact.exported_program
additional_kwargs = {}
if hasattr(serialized_ep, "verifiers"):
additional_kwargs["verifiers"] = [
load_verifier(v) for v in serialized_ep.verifiers # pyre-ignore
]
elif hasattr(serialized_ep, "dialect"):
additional_kwargs["verifier"] = load_verifier(
serialized_ep.dialect # pyre-ignore
)
exported_program = exir.ExportedProgram(
root=state_dict,
graph=dummy_g,
graph_signature=ep.ExportGraphSignature(input_specs=[], output_specs=[]),
state_dict=state_dict, # TODO(T157676982)
range_constraints=range_constraints,
module_call_graph=module_call_graph,
verifier=load_verifier(
serialized_artifact.exported_program.dialect # pyre-ignore
),
**additional_kwargs,
)
exported_program.graph_module.graph = graph_module.graph
exported_program._graph_signature = res.signature
Expand Down
Loading