Skip to content

Commit dbb475a

Browse files
Songhao Jiafacebook-github-bot
authored andcommitted
move apis for BP creation under bundled_program/bundler (#1019)
Summary: Pull Request resolved: #1019 Pull Request resolved: #435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: https://internalfb.com/D50422556 fbshipit-source-id: 8b2b56a81d7bef6c34e4e0e539d113ddb7980b6d
1 parent b168fb3 commit dbb475a

File tree

22 files changed

+92
-80
lines changed

22 files changed

+92
-80
lines changed

backends/apple/mps/test/test_mps.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
TestMPS,
2626
)
2727

28-
from executorch.sdk.bundled_program.config import MethodTestCase, MethodTestSuite
29-
from executorch.sdk.bundled_program.core import create_bundled_program
28+
from executorch.sdk.bundled_program.bundler.config import MethodTestCase, MethodTestSuite
29+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
3030
from executorch.sdk.bundled_program.serialize import (
3131
serialize_from_bundled_program_to_flatbuffer,
3232
)

backends/apple/mps/test/test_mps_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
from executorch.exir.backend.backend_api import to_backend, validation_disabled
1717

1818
from executorch.exir.print_program import print_program
19-
from executorch.sdk.bundled_program.config import MethodTestCase, MethodTestSuite
20-
from executorch.sdk.bundled_program.core import create_bundled_program
19+
from executorch.sdk.bundled_program.bundler.config import MethodTestCase, MethodTestSuite
20+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
2121
from executorch.sdk.bundled_program.serialize import (
2222
serialize_from_bundled_program_to_flatbuffer,
2323
)

backends/xnnpack/test/TARGETS

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ python_unittest(
2626
"//executorch/exir/passes:spec_prop_pass",
2727
"//executorch/extension/pybindings:portable_lib", # @manual
2828
"//executorch/extension/pytree:pylib",
29-
"//executorch/sdk/bundled_program:config",
30-
"//executorch/sdk/bundled_program:core",
29+
"//executorch/sdk/bundled_program/bundler:config",
30+
"//executorch/sdk/bundled_program/bundler:core",
3131
"//executorch/sdk/bundled_program/serialize:lib",
3232
],
3333
)
@@ -55,8 +55,8 @@ python_unittest(
5555
"//executorch/exir/passes:spec_prop_pass",
5656
"//executorch/extension/pybindings:portable_lib", # @manual
5757
"//executorch/extension/pytree:pylib",
58-
"//executorch/sdk/bundled_program:config",
59-
"//executorch/sdk/bundled_program:core",
58+
"//executorch/sdk/bundled_program/bundler:config",
59+
"//executorch/sdk/bundled_program/bundler:core",
6060
"//executorch/sdk/bundled_program/serialize:lib",
6161
],
6262
)
@@ -83,8 +83,8 @@ python_unittest(
8383
"//executorch/exir/passes:spec_prop_pass",
8484
"//executorch/extension/pybindings:portable_lib", # @manual
8585
"//executorch/extension/pytree:pylib",
86-
"//executorch/sdk/bundled_program:config",
87-
"//executorch/sdk/bundled_program:core",
86+
"//executorch/sdk/bundled_program/bundler:config",
87+
"//executorch/sdk/bundled_program/bundler:core",
8888
"//executorch/sdk/bundled_program/serialize:lib",
8989
"//pytorch/vision:torchvision",
9090
],

backends/xnnpack/test/test_xnnpack_utils.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,11 @@
3535
)
3636
from executorch.extension.pytree import tree_flatten
3737

38-
from executorch.sdk.bundled_program.config import MethodTestCase, MethodTestSuite
39-
from executorch.sdk.bundled_program.core import create_bundled_program
38+
from executorch.sdk.bundled_program.bundler.config import (
39+
MethodTestCase,
40+
MethodTestSuite,
41+
)
42+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
4043
from executorch.sdk.bundled_program.serialize import (
4144
serialize_from_bundled_program_to_flatbuffer,
4245
)

docs/source/sdk-bundled-io.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ Here is a flow highlighting how to generate a `BundledProgram` given a PyTorch m
8686

8787
import torch
8888

89-
from executorch.sdk.bundled_program.config import MethodTestCase, MethodTestSuite
90-
from executorch.sdk.bundled_program.core import create_bundled_program
89+
from executorch.sdk.bundled_program.bundler.config import MethodTestCase, MethodTestSuite
90+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
9191
from executorch.sdk.bundled_program.serialize import (
9292
serialize_from_bundled_program_to_flatbuffer,
9393
)
@@ -324,8 +324,8 @@ Here's the example of the dtype of test input not meet model's requirement:
324324
```python
325325
import torch
326326
327-
from executorch.sdk.bundled_program.config import MethodTestCase, MethodTestSuite
328-
from executorch.sdk.bundled_program.core import create_bundled_program
327+
from executorch.sdk.bundled_program.bundler.config import MethodTestCase, MethodTestSuite
328+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
329329
330330
from executorch.exir import to_edge
331331
from torch.export import export
@@ -459,8 +459,8 @@ Another common error would be the method name in any `MethodTestSuite` does not
459459
```python
460460
import torch
461461

462-
from executorch.sdk.bundled_program.config import MethodTestCase, MethodTestSuite
463-
from executorch.sdk.bundled_program.core import create_bundled_program
462+
from executorch.sdk.bundled_program.bundler.config import MethodTestCase, MethodTestSuite
463+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
464464

465465
from executorch.exir import to_edge
466466
from torch.export import export

examples/apple/mps/scripts/mps_example.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
import torch._export as export
1414
from executorch import exir
1515
from executorch.backends.apple.mps.mps_preprocess import MPSBackend
16-
from executorch.sdk.bundled_program.config import MethodTestCase, MethodTestSuite
17-
from executorch.sdk.bundled_program.core import create_bundled_program
16+
from executorch.sdk.bundled_program.bundler.config import MethodTestCase, MethodTestSuite
17+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
1818
from executorch.sdk.bundled_program.serialize import (
1919
serialize_from_bundled_program_to_flatbuffer,
2020
)

examples/sdk/scripts/export_bundled_program.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212

1313
import torch
1414
from executorch.exir.schema import Program
15-
from executorch.sdk.bundled_program.config import (
15+
from executorch.sdk.bundled_program.bundler.config import (
1616
MethodInputType,
1717
MethodTestCase,
1818
MethodTestSuite,
1919
)
20-
from executorch.sdk.bundled_program.core import create_bundled_program
20+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
2121
from executorch.sdk.bundled_program.serialize import (
2222
serialize_from_bundled_program_to_flatbuffer,
2323
)

exir/_serialize/TARGETS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ runtime.python_library(
5151
"//executorch/extension/pybindings/test:test",
5252
"//executorch/extension/pybindings/test:test-library",
5353
"//executorch/profiler/...",
54-
"//executorch/sdk/bundled_program:core",
54+
"//executorch/sdk/bundled_program/bundler:core",
5555
"//executorch/sdk/bundled_program/serialize:lib",
5656
"//executorch/sdk/bundled_program/tests/...",
5757
"//executorch/sdk/experimental/...",

sdk/bundled_program/TARGETS

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -2,33 +2,6 @@ load("@fbcode_macros//build_defs:python_library.bzl", "python_library")
22

33
oncall("executorch")
44

5-
python_library(
6-
name = "core",
7-
srcs = [
8-
"core.py",
9-
],
10-
deps = [
11-
":config",
12-
":schema",
13-
":version",
14-
"//caffe2:torch",
15-
"//executorch/exir:schema",
16-
"//executorch/exir:tensor",
17-
"//executorch/exir/_serialize:lib",
18-
],
19-
)
20-
21-
python_library(
22-
name = "config",
23-
srcs = [
24-
"config.py",
25-
],
26-
deps = [
27-
"fbsource//third-party/pypi/typing-extensions:typing-extensions",
28-
"//caffe2:torch",
29-
],
30-
)
31-
325
python_library(
336
name = "schema",
347
srcs = [
@@ -38,10 +11,3 @@ python_library(
3811
"//executorch/exir:scalar_type",
3912
],
4013
)
41-
42-
python_library(
43-
name = "version",
44-
srcs = [
45-
"version.py",
46-
],
47-
)

sdk/bundled_program/bundler/TARGETS

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
load("@fbcode_macros//build_defs:python_library.bzl", "python_library")
2+
3+
oncall("executorch")
4+
5+
python_library(
6+
name = "core",
7+
srcs = [
8+
"core.py",
9+
],
10+
deps = [
11+
":config",
12+
":version",
13+
"//caffe2:torch",
14+
"//executorch/exir:schema",
15+
"//executorch/exir:tensor",
16+
"//executorch/exir/_serialize:lib",
17+
"//executorch/sdk/bundled_program:schema",
18+
],
19+
)
20+
21+
python_library(
22+
name = "config",
23+
srcs = [
24+
"config.py",
25+
],
26+
deps = [
27+
"fbsource//third-party/pypi/typing-extensions:typing-extensions",
28+
"//caffe2:torch",
29+
],
30+
)
31+
32+
python_library(
33+
name = "version",
34+
srcs = [
35+
"version.py",
36+
],
37+
)
File renamed without changes.

sdk/bundled_program/core.py renamed to sdk/bundled_program/bundler/core.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@
1717
from executorch.exir._serialize import _serialize_pte_binary
1818

1919
from executorch.exir.tensor import get_scalar_type, scalar_type_enum, TensorSpec
20-
from executorch.sdk.bundled_program.config import ConfigValue, MethodTestSuite
20+
from executorch.sdk.bundled_program.bundler.config import ConfigValue, MethodTestSuite
2121

22-
from executorch.sdk.bundled_program.version import BUNDLED_PROGRAM_SCHEMA_VERSION
22+
from executorch.sdk.bundled_program.bundler.version import (
23+
BUNDLED_PROGRAM_SCHEMA_VERSION,
24+
)
2325

2426
# pyre-ignore
2527
supported_program_type_table: Dict[Type[core_schema.KernelTypes], ConfigValue] = {

sdk/bundled_program/tests/TARGETS

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ python_library(
1616
"//caffe2:torch",
1717
"//executorch/exir:lib",
1818
"//executorch/exir:schema",
19-
"//executorch/sdk/bundled_program:config",
19+
"//executorch/sdk/bundled_program/bundler:config",
2020
],
2121
)
2222

@@ -29,9 +29,9 @@ python_unittest(
2929
":lib",
3030
"//caffe2:torch",
3131
"//executorch/exir/_serialize:lib",
32-
"//executorch/sdk/bundled_program:config",
33-
"//executorch/sdk/bundled_program:core",
3432
"//executorch/sdk/bundled_program:schema",
33+
"//executorch/sdk/bundled_program/bundler:config",
34+
"//executorch/sdk/bundled_program/bundler:core",
3535
],
3636
)
3737

@@ -43,7 +43,7 @@ python_unittest(
4343
deps = [
4444
":lib",
4545
"//executorch/exir:print_program",
46-
"//executorch/sdk/bundled_program:core",
46+
"//executorch/sdk/bundled_program/bundler:core",
4747
"//executorch/sdk/bundled_program/serialize:lib",
4848
],
4949
)
@@ -57,7 +57,7 @@ python_unittest(
5757
":lib",
5858
"//caffe2:torch",
5959
"//executorch/extension/pytree:pylib",
60-
"//executorch/sdk/bundled_program:config",
60+
"//executorch/sdk/bundled_program/bundler:config",
6161
],
6262
)
6363

@@ -85,8 +85,8 @@ python_unittest(
8585
"//executorch/extension/pybindings:portable_lib",
8686
"//executorch/extension/pytree:pybindings",
8787
"//executorch/kernels/portable:custom_ops_generated_lib",
88-
"//executorch/sdk/bundled_program:config",
89-
"//executorch/sdk/bundled_program:core",
88+
"//executorch/sdk/bundled_program/bundler:config",
89+
"//executorch/sdk/bundled_program/bundler:core",
9090
"//executorch/sdk/bundled_program/serialize:lib",
9191
],
9292
)

sdk/bundled_program/tests/common.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@
1010
from typing import List, Tuple
1111

1212
import executorch.exir as exir
13+
1314
import torch
1415
from executorch.exir.schema import Program
15-
from executorch.sdk.bundled_program.config import (
16+
from executorch.sdk.bundled_program.bundler.config import (
1617
MethodInputType,
1718
MethodOutputType,
1819
MethodTestCase,

sdk/bundled_program/tests/test_bundle_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313

1414
import torch
1515
from executorch.exir._serialize import _serialize_pte_binary
16-
from executorch.sdk.bundled_program.config import ConfigValue
17-
from executorch.sdk.bundled_program.core import create_bundled_program
16+
from executorch.sdk.bundled_program.bundler.config import ConfigValue
17+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
1818
from executorch.sdk.bundled_program.tests.common import get_common_program
1919

2020

sdk/bundled_program/tests/test_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
import torch
1313
from executorch.extension.pytree import tree_flatten
14-
from executorch.sdk.bundled_program.config import DataContainer
14+
from executorch.sdk.bundled_program.bundler.config import DataContainer
1515

1616
from executorch.sdk.bundled_program.tests.common import (
1717
get_random_test_suites,

sdk/bundled_program/tests/test_end2end.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
import torch
2323

24-
from executorch.sdk.bundled_program.core import create_bundled_program
24+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
2525
from executorch.sdk.bundled_program.serialize import (
2626
serialize_from_bundled_program_to_flatbuffer,
2727
)

sdk/bundled_program/tests/test_serialize.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
from executorch.exir.print_program import pretty_print
1212

13-
from executorch.sdk.bundled_program.core import create_bundled_program
13+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
1414

1515
from executorch.sdk.bundled_program.serialize import (
1616
deserialize_from_flatbuffer_to_bundled_program,

test/end2end/TARGETS

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ python_unittest(
5656
"//executorch/extension/pybindings:aten_lib",
5757
"//executorch/extension/pytree:pybindings",
5858
"//executorch/kernels/portable:custom_ops_generated_lib",
59-
"//executorch/sdk/bundled_program:config",
60-
"//executorch/sdk/bundled_program:core",
59+
"//executorch/sdk/bundled_program/bundler:config",
60+
"//executorch/sdk/bundled_program/bundler:core",
6161
"//executorch/sdk/bundled_program/serialize:lib",
6262
],
6363
)
@@ -88,8 +88,8 @@ python_unittest(
8888
"//executorch/extension/pybindings:portable_lib",
8989
"//executorch/extension/pytree:pybindings",
9090
"//executorch/kernels/portable:custom_ops_generated_lib",
91-
"//executorch/sdk/bundled_program:config",
92-
"//executorch/sdk/bundled_program:core",
91+
"//executorch/sdk/bundled_program/bundler:config",
92+
"//executorch/sdk/bundled_program/bundler:core",
9393
"//executorch/sdk/bundled_program/serialize:lib",
9494
],
9595
)

test/models/generate_linear_out_bundled_program.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,11 @@
2222
from executorch.exir import ExecutorchBackendConfig
2323
from executorch.exir.passes import MemoryPlanningPass, ToOutVarPass
2424
from executorch.exir.print_program import pretty_print
25-
from executorch.sdk.bundled_program.config import MethodTestCase, MethodTestSuite
26-
from executorch.sdk.bundled_program.core import create_bundled_program
25+
from executorch.sdk.bundled_program.bundler.config import (
26+
MethodTestCase,
27+
MethodTestSuite,
28+
)
29+
from executorch.sdk.bundled_program.bundler.core import create_bundled_program
2730
from executorch.sdk.bundled_program.serialize import (
2831
serialize_from_bundled_program_to_flatbuffer,
2932
)

test/models/targets.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ def define_common_targets():
2222
deps = [
2323
":linear_model",
2424
"//caffe2:torch",
25-
"//executorch/sdk/bundled_program:config",
26-
"//executorch/sdk/bundled_program:core",
25+
"//executorch/sdk/bundled_program/bundler:config",
26+
"//executorch/sdk/bundled_program/bundler:core",
2727
"//executorch/sdk/bundled_program/serialize:lib",
2828
"//executorch/exir:lib",
2929
"//executorch/exir/_serialize:lib",

0 commit comments

Comments
 (0)