-
Notifications
You must be signed in to change notification settings - Fork 607
move aot apis under executorch/bundled_program/aot #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch/executorch#396 This diff creates a unique namespace for bundled program from core executorch schema. Such update can make bundled program more decomposed from core ET. Differential Revision: https://internalfb.com/D49326299 fbshipit-source-id: ff989067dc58823cc11d91b3ea1e8ab73a095134
Summary: Pull Request resolved: pytorch/executorch#397 Now we already have a specific namespace for bundledprogram, this diff removes the "Bundled" prefix for part of bundled program schema's variables. Rest variables will be updated in the following diffs. Differential Revision: https://internalfb.com/D49337170 fbshipit-source-id: 3a2730d20981d3411907950b8a43b51f7b001e0c
Summary: Pull Request resolved: pytorch/executorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: https://internalfb.com/D49406613 fbshipit-source-id: 43acf8e85830b615977beaeee5f083e161a633f3
Summary: This stack focuses on moving all bundled program codes under executorch/bundled_program. Target logic will be: bundled_program ├── aot (aot apis and schema.py) ├── runtime (runtime apis and schema.fbs) ├── serialize (bp serialization and deserialization) └── tests This diff moves all aot apis under bundled_program/aot, and update dependencies. Differential Revision: D49449640 fbshipit-source-id: 97ba124c0f66d706265bc4cf7b4f0c334b89050b
This pull request was exported from Phabricator. Differential Revision: D49449640 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: D50422556 fbshipit-source-id: 077fa1fd228b6d4deff6c89fca2e81c7b40c82c6
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: D50422556 fbshipit-source-id: 38576f5958b7416c4a0cb71514acf5c71bac304b
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: D50422556 fbshipit-source-id: c5772b5f7b3ef74ba9199bf14b0e7199a0b3a9e5
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: D50422556 fbshipit-source-id: 3a803d0f6840e34030675129024bd1bb276ba7c8
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: D50422556 fbshipit-source-id: 38b6b81ef98aa16b245d1174b74bd29eb45b0e6f
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: D50422556 fbshipit-source-id: 5c6d820ac292ca1dfd3b4a48228038a050c32338
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: https://internalfb.com/D50422556 fbshipit-source-id: da8769810e79e3577a132596167cd046d1e57868
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: https://internalfb.com/D50422556 fbshipit-source-id: 9e2e91696afe881ccec695e5d57c7199877ddd9b
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: https://internalfb.com/D50422556 fbshipit-source-id: 9c4144673ae679da08223d2d5841f6e8337e7e57
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: D50422556 fbshipit-source-id: baa3f7d975a472e277128a5a80294e25b2d91cab
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: https://internalfb.com/D50422556 fbshipit-source-id: 75936909b44707fb8d2ba17c306f2a55497f6125
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: D50422556 fbshipit-source-id: b65a2187151d947ed500777c856d882e9ab2e323
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: https://internalfb.com/D50422556 fbshipit-source-id: f46de11168e1602d86898a784c4a81a3e54ab17e
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 23, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: https://internalfb.com/D50422556 fbshipit-source-id: 0dd6414af197f14acf53ddf1b9b2bcd2c3e86d5a
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 23, 2023
Summary: Pull Request resolved: pytorch#1019 Pull Request resolved: pytorch#435 This stack focuses on moving all bundled program codes under executorch/sdk/bundled_program. Target and discussions can be found in D49605947. This diff moves all apis for bundled program creation under bundled_program/bundler, and update dependencies. Differential Revision: https://internalfb.com/D50422556 fbshipit-source-id: 8b2b56a81d7bef6c34e4e0e539d113ddb7980b6d
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Add support for tiktoken and refactored runner structure Summary: Unified runner and move runner-et/CMakeLists.txt to runner/et.cmake and runner-aoti/CMakeLists.txt to runner/aoti.cmake. Added a root level CMakeLists.txt to build a tokenizer library and link to both targets separately. In CLI we need to specify the target to run: ``` cmake --build ./cmake-out --target et_run/aoti_run ``` Test Plan: Reviewers: Subscribers: Tasks: Tags: * Fix CI Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Fix more CI Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Further fix CI Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Lint` Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Update build_android.sh Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Rebase Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Fix cmake commands in CI job Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This stack focuses on moving all bundled program codes under executorch/bundled_program.
Target logic will be:
bundled_program
├── aot (aot apis and schema.py)
├── runtime (runtime apis and schema.fbs)
├── serialize (bp serialization and deserialization)
└── tests
This diff moves all aot apis under bundled_program/aot, and update dependencies.
Differential Revision: D49449640