structural api and schema update #410
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49406613 |
|
This pull request was exported from Phabricator. Differential Revision: D49406613 |
Gasoonjia
force-pushed
the
export-D49406613
branch
from
f0533a4 to
be7efe5
Compare
Summary: Pull Request resolved: pytorch/executorch#396 This diff creates a unique namespace for bundled program from core executorch schema. Such update can make bundled program more decomposed from core ET. Differential Revision: https://internalfb.com/D49326299 fbshipit-source-id: 259480d01795626ef7ea2074955de509b2ed3b9e
Summary: Pull Request resolved: pytorch/executorch#397 Now we already have a specific namespace for bundledprogram, this diff removes the "Bundled" prefix for part of bundled program schema's variables. Rest variables will be updated in the following diffs. Differential Revision: https://internalfb.com/D49337170 fbshipit-source-id: a855f6296650ed5008a412938b8492d161454cf2
Summary: Pull Request resolved: pytorch/executorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D49406613 fbshipit-source-id: 3741c769ea84105b1e64c0f1e6503b6903b91057
|
This pull request was exported from Phabricator. Differential Revision: D49406613 |
Gasoonjia
force-pushed
the
export-D49406613
branch
from
be7efe5 to
4aeddf1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49406613 |
4 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D49406613 |
|
This pull request was exported from Phabricator. Differential Revision: D49406613 |
|
This pull request was exported from Phabricator. Differential Revision: D49406613 |
|
This pull request was exported from Phabricator. Differential Revision: D49406613 |
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 18, 2023
Summary: Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 18, 2023
Summary: Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: a1154a19514324019e1ec7f590ed6a19583ecf99
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: d23c842acb105b34436764bf346effc2af8ae9da
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: fc65f20001a6925e981263b64a9fa8a9c21bd9e2
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: 1f7331c4463ea6c4ad4e5a93a81d570633711062
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: 7e1a9429226f27fe18f9d80cc434e0ac6a6231c6
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: 2e5293034c4737be2a72fc9565eade984636d87e
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: c347b50578bd2bdcd7e9ef81e68849e046876c70
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: e379b9cb7da0ae9fb97252d4c52aaa23894feac2
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: 92ecd69a6c43bbdb78585a596ccdd9ca916f8b9f
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: 096ad8e35f86937babeb9a9a518c5b81b3e1f2e1
Gasoonjia
pushed a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#410 Update the AOT API for bundled program to make it more user friendly. We created two new classes for holding testcases in a more structural way: MethodTestCase: contains inputs and expected outputs for a single test for method. MethodTestSuite: Collection of all test cases for a program method. Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n Differential Revision: D50422563 fbshipit-source-id: e0f8f6438df4af593f1cc135a39da4a8860174a8
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update the AOT API for bundled program to make it more user friendly.
We created two new classes for holding testcases in a more structural way:
MethodTestCase: contains inputs and expected outputs for a single test for method.
MethodTestSuite: Collection of all test cases for a program method.
Detailed design can be found here: https://docs.google.com/document/d/170WJ81dPuNQsvsjqH_wQjafbu2kxtEG1sgX-z6OqCEI/edit#heading=h.69fgezruwl6n
Differential Revision: D49406613