Remove getter for event_blocks (#581)

Summary:
Pull Request resolved: #581

Remove the getter function because it's more Pythonic to just access the attributes (I read this [article](https://realpython.com/python-getter-setter/#:~:text=In%20OOP%2C%20the%20getter%20and,use%20getter%20and%20setter%20methods.) says so).

Reviewed By: Jack-Khuu

Differential Revision: D49853351

fbshipit-source-id: 54c5f5fef3ad52887a58d252a780fb98ea4e4334

Author: Olivia-liu

sdk/inspector/inspector.py

@@ -364,7 +364,7 @@ class Inspector:
     APIs for examining model architecture and performance stats.
 
     Public Attributes:
-        event_blocks: List["EventBlocks"]. Structured data accessible through Inspector for analysis.
+        event_blocks: List["EventBlocks"]. Structured data from ETDump (correlated with ETRecord if provided).
 
     Private Attributes:
         _etrecord: Optional[ETRecord]. File under etrecord_path deserialized into an object.
@@ -461,12 +461,6 @@ def find_total_for_module(self, module_name: str):
                         break
         return total
 
-    def get_event_blocks(self) -> List[EventBlock]:
-        """
-        Returns EventBlocks containing contents from ETDump (correlated to ETRecord if provided)
-        """
-        return self.event_blocks
-
     def get_op_list(
         self, event_block: str, show_delegated_ops: Optional[bool] = True
     ) -> Dict[str, List[Event]]:

sdk/inspector/tests/inspector_test.py

@@ -75,7 +75,7 @@ def test_inspector_constructor(self):
             # Because we mocked parse_etrecord() to return None, this method shouldn't be called
             mock_gen_graphs_from_etrecord.assert_not_called()
 
-    def test_inspector_get_event_blocks_and_print_data_tabular(self):
+    def test_inspector_print_data_tabular(self):
         # Create a context manager to patch functions called by Inspector.__init__
         with patch.object(inspector, "parse_etrecord", return_value=None), patch.object(
             inspector, "gen_etdump_object", return_value=None
@@ -88,14 +88,11 @@ def test_inspector_get_event_blocks_and_print_data_tabular(self):
                 etrecord_path=ETRECORD_PATH,
             )
 
-            # Test get_event_blocks() method. The mock inspector instance should start with having an empty event blocks list
-            event_block_list = [
+            # The mock inspector instance starts with having an empty event blocks list.
+            # Add non-empty event blocks to test print_data_tabular().
+            inspector_instance.event_blocks = [
                 EventBlock(name=EVENT_BLOCK_NAME, events=self._gen_random_events())
             ]
-            # Add non-empty event blocks to test get_event_blocks() and print_data_tabular()
-            inspector_instance.event_blocks = event_block_list
-            self.assertEqual(inspector_instance.get_event_blocks(), event_block_list)
-
             # Call print_data_tabular(), make sure it doesn't crash
             with redirect_stdout(None):
                 inspector_instance.print_data_tabular()