Remove getter for event_blocks #581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49853351 |
|
This pull request was exported from Phabricator. Differential Revision: D49853351 |
Olivia-liu
force-pushed
the
export-D49853351
branch
from
22bb48b to
bbcc633
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49853351 |
Olivia-liu
force-pushed
the
export-D49853351
branch
from
bbcc633 to
f5d4f10
Compare
Differential Revision: D49844340 fbshipit-source-id: 7606494cb18f0dc95cdfac7520922c470525c186
Summary: Pull Request resolved: pytorch/executorch#581 Remove the getter function because it's more Pythonic to just access the attributes (I read this [article](https://realpython.com/python-getter-setter/#:~:text=In%20OOP%2C%20the%20getter%20and,use%20getter%20and%20setter%20methods.) says so). Reviewed By: Jack-Khuu Differential Revision: D49853351 fbshipit-source-id: de0f331bda37d8707eba3ea1545b7c96bde63f11
|
This pull request was exported from Phabricator. Differential Revision: D49853351 |
Olivia-liu
force-pushed
the
export-D49853351
branch
from
f5d4f10 to
87aefc8
Compare
|
This pull request has been merged in ee4d98b. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* executable README * fix title of CI workflow * markup commands in markdown * extend the markup-markdown language * Automatically identify cuda from nvidia-smi in install-requirements (#606) * Automatically identify cuda from nvidia-smi in install-requirements * Update README.md --------- Co-authored-by: Michael Gschwind <[email protected]> * Unbreak zero-temperature sampling (#599) Fixes #581. * Improve process README * [retake] Add sentencepiece tokenizer (#626) * Add sentencepiece tokenizer Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add white space Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Handle white space: Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Handle control ids Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * More cleanup Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Lint Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Use unique_ptr Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Use a larger runner Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Debug Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Debug Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Cleanup * Update install_utils.sh to use python3 instead of python (#636) As titled. On some devices `python` and `python3` are pointing to different environments so good to unify them. * Fix quantization doc to specify dytpe limitation on a8w4dq (#629) Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Co-authored-by: Kimish Patel <[email protected]> * add desktop.json (#622) * add desktop.json * add fast * remove embedding * improvements * update readme from doc branch * tab/spc * fix errors in updown language * fix errors in updown language, and [skip]: begin/end * fix errors in updown language, and [skip]: begin/end * a storied run * stories run on readme instructions does not need HF token * increase timeout * check for hang un hf_login * executable README improvements * typo * typo --------- Co-authored-by: Ian Barber <[email protected]> Co-authored-by: Scott Wolchok <[email protected]> Co-authored-by: Mengwei Liu <[email protected]> Co-authored-by: Kimish Patel <[email protected]> Co-authored-by: Scott Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Remove the getter function because it's more Pythonic to just access the attributes (I read this article says so).
Differential Revision: D49853351