Skip to content

[executorch] Refactor install_flatc.sh #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[executorch] Refactor install_flatc.sh #606

wants to merge 2 commits into from

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Oct 4, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes various problems I ran into while running it on my system.

  • Sets up the cmake cache for flatc so it can build
  • Doesn't look at stderr when examining the flatc path
  • Runs properly even when the working directory is not at the root of the tree
  • Uses echo -e to print colors correctly
  • Use double quotes and braces on all variables
  • Add strict error and undefined var checking
  • Refactor as a set of functions instead of running at the top level

Differential Revision: D49897273

@dbort
[executorch] Refactor install_flatc.sh
413487a 
Fixes various problems I ran into while running it on my system.
- Sets up the cmake cache for flatc so it can build
- Doesn't look at stderr when examining the flatc path
- Runs properly even when the working directory is not at the root of the tree
- Uses `echo -e` to print colors correctly
- Use double quotes and braces on all variables
- Add strict error and undefined var checking
- Refactor as a set of functions instead of running at the top level

Differential Revision: [D49897273](https://our.internmc.facebook.com/intern/diff/D49897273/)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2023
dbort added a commit that referenced this pull request Oct 4, 2023
@dbort
[executorch] Refactor install_flatc.sh
ab61a38 
Fixes various problems I ran into while running it on my system.
- Sets up the cmake cache for flatc so it can build
- Doesn't look at stderr when examining the flatc path
- Runs properly even when the working directory is not at the root of the tree
- Uses `echo -e` to print colors correctly
- Use double quotes and braces on all variables
- Add strict error and undefined var checking
- Refactor as a set of functions instead of running at the top level

Differential Revision: [D49897273](https://our.internmc.facebook.com/intern/diff/D49897273/)

ghstack-source-id: 202829279
Pull Request resolved: #606
@dbort
Update on "[executorch] Refactor install_flatc.sh"
2c98bad 
Fixes various problems I ran into while running it on my system.
- Sets up the cmake cache for flatc so it can build
- Doesn't look at stderr when examining the flatc path
- Runs properly even when the working directory is not at the root of the tree
- Uses `echo -e` to print colors correctly
- Use double quotes and braces on all variables
- Add strict error and undefined var checking
- Refactor as a set of functions instead of running at the top level

Differential Revision: [D49897273](https://our.internmc.facebook.com/intern/diff/D49897273/)

[ghstack-poisoned]
dbort added a commit that referenced this pull request Oct 4, 2023
@dbort
[executorch] Refactor install_flatc.sh
21f0f5e 
Pull Request resolved: #606

Fixes various problems I ran into while running it on my system.
- Sets up the cmake cache for flatc so it can build
- Doesn't look at stderr when examining the flatc path
- Runs properly even when the working directory is not at the root of the tree
- Uses `echo -e` to print colors correctly
- Use double quotes and braces on all variables
- Add strict error and undefined var checking
- Refactor as a set of functions instead of running at the top level
ghstack-source-id: 202918208
@exported-using-ghexport

Differential Revision: [D49897273](https://our.internmc.facebook.com/intern/diff/D49897273/)
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0e5ddd1.

@facebook-github-bot facebook-github-bot deleted the gh/dbort/28/head branch October 8, 2023 14:21
Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
@ianbarber @mikekgfb @malfet
Automatically identify cuda from nvidia-smi in install-requirements (#…
46a6b9c 
…606)

* Automatically identify cuda from nvidia-smi in install-requirements

* Update README.md

---------

Co-authored-by: Michael Gschwind <[email protected]>
Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
@mikekgfb @ianbarber
@swolchok @larryliu0820 @kimishpatel @metascroy @malfet
Process readme (#665)
86c50df 
* executable README

* fix title of CI workflow

* markup commands in markdown

* extend the markup-markdown language

* Automatically identify cuda from nvidia-smi in install-requirements (#606)

* Automatically identify cuda from nvidia-smi in install-requirements

* Update README.md

---------

Co-authored-by: Michael Gschwind <[email protected]>

* Unbreak zero-temperature sampling (#599)

Fixes #581.

* Improve process README

* [retake] Add sentencepiece tokenizer (#626)

* Add sentencepiece tokenizer

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add white space

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Handle white space:

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Handle control ids

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* More cleanup

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Lint

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Use unique_ptr

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Use a larger runner

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Debug

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Debug

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Cleanup

* Update install_utils.sh to use python3 instead of python (#636)

As titled. On some devices `python` and `python3` are pointing to different environments so good to unify them.

* Fix quantization doc to specify dytpe limitation on a8w4dq (#629)

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Co-authored-by: Kimish Patel <[email protected]>

* add desktop.json (#622)

* add desktop.json

* add fast

* remove embedding

* improvements

* update readme from doc branch

* tab/spc

* fix errors in updown language

* fix errors in updown language, and [skip]: begin/end

* fix errors in updown language, and [skip]: begin/end

* a storied run

* stories run on readme instructions does not need HF token

* increase timeout

* check for hang un hf_login

* executable README improvements

* typo

* typo

---------

Co-authored-by: Ian Barber <[email protected]>
Co-authored-by: Scott Wolchok <[email protected]>
Co-authored-by: Mengwei Liu <[email protected]>
Co-authored-by: Kimish Patel <[email protected]>
Co-authored-by: Scott Roy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbort @facebook-github-bot