-
Notifications
You must be signed in to change notification settings - Fork 608
Recipe and Input class definitions with e2e export #10034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e42c965
Recipe and Input class definitions with e2e export
tarun292 a9d80f1
Update base for Update on "Recipe and Input class definitions with e2…
tarun292 bba10a0
Update on "Recipe and Input class definitions with e2e export"
tarun292 9964bf2
Update base for Update on "Recipe and Input class definitions with e2…
tarun292 7a9043e
Update on "Recipe and Input class definitions with e2e export"
tarun292 e3076b7
Update base for Update on "Recipe and Input class definitions with e2…
tarun292 d565702
Update on "Recipe and Input class definitions with e2e export"
tarun292 edc5f11
Update base for Update on "Recipe and Input class definitions with e2…
tarun292 36c0298
Update on "Recipe and Input class definitions with e2e export"
tarun292 2a65fab
Merge branch 'main' into gh/tarun292/4/head
tarun292 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
load("@fbcode_macros//build_defs:python_library.bzl", "python_library") | ||
|
||
oncall("executorch") | ||
|
||
python_library( | ||
name = "recipe", | ||
srcs = [ | ||
"recipe.py", | ||
], | ||
deps = [ | ||
"//caffe2:torch", | ||
"//executorch/exir/backend:backend_api", | ||
"//executorch/exir:pass_manager", | ||
"//executorch/devtools/backend_debug:delegation_info", | ||
] | ||
) | ||
|
||
python_library( | ||
name = "export", | ||
srcs = [ | ||
"export.py", | ||
], | ||
deps = [ | ||
":recipe", | ||
"//executorch/runtime:runtime", | ||
] | ||
) | ||
|
||
python_library( | ||
name = "lib", | ||
srcs = [ | ||
"__init__.py", | ||
], | ||
deps = [ | ||
":export", | ||
":recipe", | ||
], | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# Copyright (c) Meta Platforms, Inc. and affiliates. | ||
# All rights reserved. | ||
# | ||
# This source code is licensed under the BSD-style license found in the | ||
# LICENSE file in the root directory of this source tree. | ||
|
||
""" | ||
ExecuTorch export module. | ||
|
||
This module provides the tools and utilities for exporting PyTorch models | ||
to the ExecuTorch format, including configuration, quantization, and | ||
export management. | ||
""" | ||
|
||
# pyre-strict | ||
|
||
from .export import export, ExportSession | ||
from .recipe import ExportRecipe | ||
|
||
__all__ = [ | ||
"ExportRecipe", | ||
"ExportSession", | ||
"export", | ||
] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory structure is bit confusing. People coming to ET already know export and now we are teaching them of a different export.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
executorch/lower
orexecutorch/pipeline
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought quite a bit about this, the main reasoning to call this export too is because we're consuming the export call within the API. One of the main points of this API is that if someone wants to target ExecuTorch they don't even need to learn about torch.export (although many of them probably will).