Skip to content

Arm backend: Convert asserts to raise errors in op_reciprocal #10105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

Sebastian-Larsson
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented Apr 11, 2025

Asserts are converted to proper raises to ensure graph integrity.

Improve error messages and add additional check that there's only one input.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Asserts are converted to proper raises to ensure graph integrity.

Improve error messages and add additional check that there's only one
input.

Signed-off-by: Sebastian Larsson <[email protected]>
Change-Id: If0a52025763d425bb58643ca5599e7c027cb55cf
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Apr 11, 2025
Copy link

pytorch-bot bot commented Apr 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10105

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5855655 with merge base a147346 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2025
@zingo zingo merged commit 0039b3e into pytorch:main Apr 11, 2025
168 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
Asserts are converted to proper raises to ensure graph integrity.

Improve error messages and add additional check that there's only one input.


Signed-off-by: Sebastian Larsson <[email protected]>
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
…h#10105)

Asserts are converted to proper raises to ensure graph integrity.

Improve error messages and add additional check that there's only one input.


Signed-off-by: Sebastian Larsson <[email protected]>
@Sebastian-Larsson Sebastian-Larsson deleted the assert_rec branch May 15, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants