[#9971] Gracefully error out in ETDump for set_debug_buffer #10130
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10130
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @zhongmingyuan! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "topic: not user facing" |
|
LGTM |
There was a problem hiding this comment.
Its a very good start! Thanks @zhongmingyuan!
Will stamp after ci pass!
zhongmingyuan
force-pushed
the
issue9971-debug
branch
from
7472f01 to
293230b
Compare
…ytorch#10130) ## Summary Following pytorch#9971 Start with a relatively simple method. Update set_debug_bugffer. Use ET_CHECK_OR_RETURN_ERROR instead. If unable to pass error, update the return type as Result Note: Not sure if InvalidArgument is a good one ( maybe memory not allocated?). Please feel free to comment. ##Test test/run_oss_cpp_tests.sh @Gasoonjia @zhenyan-zhang-meta Thanks
Summary
Following #9971
Start with a relatively simple method.
Update set_debug_bugffer. Use ET_CHECK_OR_RETURN_ERROR instead.
If unable to pass error, update the return type as Result
Note: Not sure if InvalidArgument is a good one ( maybe memory not allocated?). Please feel free to comment.
##Test
test/run_oss_cpp_tests.sh
@Gasoonjia @zhenyan-zhang-meta Thanks