Fix bugs in executorch package #10251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from danachang:export-D73166222

Apr 18, 2025

Contributor

danachang commented Apr 17, 2025

Summary: There were bugs in executorch, which did not update InputRecorder import from torchao given changes in the path, which also required adding dependency to import lm_eval.

Differential Revision: D73166222

danachang requested review from lucylq and jackzhxng as code owners

April 17, 2025 05:01

pytorch-bot bot commented Apr 17, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10251

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 99f9121 with merge base 1edf692 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

facebook-github-bot added the fb-exported label

Contributor Author

danachang commented Apr 17, 2025

@pytorchbot label "topic: not user facing"

pytorch-bot bot added the topic: not user facing label

danachang changed the title ~~Fix bugs in executorch package, New Commit~~ Fix bugs in executorch package

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix bugs in executorch package (pytorch#10251)

77797c2

Summary:

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from 967d0b5 to 77797c2 Compare

April 17, 2025 05:37

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix bugs in executorch package (pytorch#10251)

9e18a18

Summary:

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from 77797c2 to 9e18a18 Compare

April 17, 2025 09:02

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix bugs in executorch package (pytorch#10251)

238b7a8

Summary:
Pull Request resolved: pytorch#10251

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from 9e18a18 to 238b7a8 Compare

April 17, 2025 09:05

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix bugs in executorch package (pytorch#10251)

f9520d3

Summary:

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from 238b7a8 to f9520d3 Compare

April 17, 2025 09:21

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix bugs in executorch package (pytorch#10251)

c6367cc

Summary:

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from f9520d3 to c6367cc Compare

April 17, 2025 09:49

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix bugs in executorch package (pytorch#10251)

Summary:
Pull Request resolved: pytorch#10251

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from c6367cc to 3149297 Compare

April 17, 2025 09:54

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix lm_eval import path bugs (pytorch#10251)

d1fc97c

Summary:

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from 3149297 to d1fc97c Compare

April 17, 2025 10:09

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix lm_eval import path bugs (pytorch#10251)

ae09bc4

Summary:
Pull Request resolved: pytorch#10251

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from d1fc97c to ae09bc4 Compare

April 17, 2025 10:12

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix lm_eval import path bugs (pytorch#10251)

e198117

Summary:

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from ae09bc4 to e198117 Compare

April 17, 2025 11:10

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix lm_eval import path bugs (pytorch#10251)

762177a

Summary:

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from e198117 to 762177a Compare

April 17, 2025 11:12

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix lm_eval import path bugs (pytorch#10251)

069237a

Summary:
Pull Request resolved: pytorch#10251

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from 762177a to 069237a Compare

April 17, 2025 11:14

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix lm_eval import path bugs (pytorch#10251)

68bad18

Summary:
Pull Request resolved: pytorch#10251

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from 069237a to 68bad18 Compare

April 17, 2025 11:21

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix lm_eval import path bugs (pytorch#10251)

632d9e6

Summary:

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from 68bad18 to 632d9e6 Compare

April 17, 2025 13:05

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix lm_eval import path bugs (pytorch#10251)

dedcf25

Summary:
Pull Request resolved: pytorch#10251

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from 632d9e6 to dedcf25 Compare

April 17, 2025 13:22

jackzhxng approved these changes

View reviewed changes

danachang force-pushed the export-D73166222 branch from dedcf25 to adfd460 Compare

April 17, 2025 20:01

danachang pushed a commit to danachang/executorch that referenced this pull request


          Fix lm_eval import path bugs (pytorch#10251)

adfd460

Summary:

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Reviewed By: metascroy, jackzhxng

Differential Revision: D73166222


          Fix lm_eval import path bugs (pytorch#10251)

99f9121

Summary:
Pull Request resolved: pytorch#10251

There were bugs in `executorch`, which did not update `InputRecorder` import from `torchao` given changes in the path, which also required adding dependency to import `lm_eval`.

Reviewed By: metascroy, jackzhxng

Differential Revision: D73166222

danachang force-pushed the export-D73166222 branch from adfd460 to 99f9121 Compare

April 17, 2025 20:04

Contributor

facebook-github-bot commented Apr 17, 2025

This pull request was exported from Phabricator. Differential Revision: D73166222

facebook-github-bot merged commit 5a1aa1f into pytorch:main

88 of 90 checks passed

keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request


          Fix bugs in executorch package

f46e321

Differential Revision: D73166222

Pull Request resolved: pytorch#10251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported topic: not user facing