Skip to content

support phi4 in ios demo app #10659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025
Merged

support phi4 in ios demo app #10659

merged 3 commits into from
May 2, 2025

Conversation

metascroy
Copy link
Contributor

As titled

Copy link

pytorch-bot bot commented May 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10659

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Unrelated Failure

As of commit 0e17a9b with merge base 385d860 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2025
Copy link

github-actions bot commented May 2, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special tokens to handle?

@metascroy
Copy link
Contributor Author

Any special tokens to handle?

no, the token is handled by the runner.cpp logic because it's in the PTEs metadata.

But we should really move this logic (and the template) to the HF tokenizer. The tokenizer.json contains information about both stop tokens and template.

@jackzhxng
Copy link
Contributor

Yeah we should definitely do that, but I think the prompt templating should be outside of the tokenizer

@metascroy metascroy merged commit 3997ae9 into main May 2, 2025
185 of 188 checks passed
@metascroy metascroy deleted the support-phi4 branch May 2, 2025 22:00
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
As titled

---------

Co-authored-by: Jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants