Skip to content

extension/module should depend on executorch_core #10678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

kirklandsign
Copy link
Contributor

No need to know about prim ops. Up to user.

No need to know about prim ops. Up to user.
Copy link

pytorch-bot bot commented May 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10678

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 26b8ce9 with merge base e88aafc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2025
@kirklandsign kirklandsign added release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 5, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2025
@kirklandsign kirklandsign marked this pull request as ready for review May 5, 2025 16:41
@kirklandsign kirklandsign requested a review from shoumikhin as a code owner May 5, 2025 16:41
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit c2701f9 into main May 5, 2025
271 of 275 checks passed
@facebook-github-bot facebook-github-bot deleted the extension-module-deps branch May 5, 2025 19:32
phaiting pushed a commit that referenced this pull request May 6, 2025
Differential Revision: D74185003

Pull Request resolved: #10678
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
Differential Revision: D74185003

Pull Request resolved: pytorch#10678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants