Skip to content

Remove unused vulkan_executor_runner_lib #10679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented May 5, 2025

If some executor_runner needs to use vulkan, just add vulkan_schema and vulkan_backend

cc @SS-JIA @manuelcandales @cbilgin

If some executor_runner needs to use vulkan, just add vulkan_schema and vulkan_backend
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label May 5, 2025
Copy link

pytorch-bot bot commented May 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10679

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 2 Pending

As of commit 3082691 with merge base 319e88d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2025
@kirklandsign kirklandsign added topic: not user facing and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ labels May 5, 2025
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label May 5, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2025
@kirklandsign kirklandsign marked this pull request as ready for review May 5, 2025 16:44
@kirklandsign kirklandsign requested a review from SS-JIA as a code owner May 5, 2025 16:44
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 34f5240 into main May 5, 2025
84 of 86 checks passed
@facebook-github-bot facebook-github-bot deleted the vulkan-unused-lib branch May 5, 2025 20:33
phaiting pushed a commit that referenced this pull request May 6, 2025
Differential Revision: D74184993

Pull Request resolved: #10679
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
Differential Revision: D74184993

Pull Request resolved: pytorch#10679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants